Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Don't assume window is always available for inabox. It can be already destroyed #26265

Merged
merged 2 commits into from
Jan 9, 2020
Merged

🐛 Don't assume window is always available for inabox. It can be already destroyed #26265

merged 2 commits into from
Jan 9, 2020

Conversation

lannka
Copy link
Contributor

@lannka lannka commented Jan 8, 2020

Fixes #22961

@lannka lannka requested a review from powerivq January 8, 2020 23:24
@lannka lannka merged commit 5bfb0e5 into ampproject:master Jan 9, 2020
@lannka lannka deleted the fix-frameElement-of-null branch January 9, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerivq powerivq powerivq approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read property 'frameElement' of null
4 participants
@lannka @powerivq @googlebot @ampprojectbot