🐛 Don't assume window is always available for inabox. It can be alrea…

…dy destroyed (#26265) * Don't assume window is always available for inabox. It can be already destroyed. * address comments
ampproject · Jan 9, 2020 · 5bfb0e5 · 5bfb0e5
1 parent 689a9c7
commit 5bfb0e5
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/ads/inabox/position-observer.js b/ads/inabox/position-observer.js
@@ -136,7 +136,11 @@ export class PositionObserver {
     const parentWin = element.ownerDocument.defaultView;
     for (
       let j = 0, tempWin = parentWin;
-      j < 10 && tempWin != this.win_ && tempWin != this.win_.top;
+      j < 10 &&
+      // win can be null if the ad iframe is already destroyed
+      tempWin &&
+      tempWin != this.win_ &&
+      tempWin != this.win_.top;
       j++, tempWin = tempWin.parent
     ) {
       const parentFrameRect = layoutRectFromDomRect(