✨Make "layout=intrinsic" compatible with SSR #23831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles resize events by setting intrinsic layout's img src to ''. This does not include validator updates to support the intrinsic sizer. Fixes ampproject#17686
jridgewell
reviewed
Aug 8, 2019
src/custom-element.js
Outdated
| return; | ||
| } | ||
| if (this.layout_ === Layout.INTRINSIC) { | ||
| const sizerElement = sizer.querySelector('.i-amphtml-intrinsic-sizer'); |
There was a problem hiding this comment.
Is this not the sizer variable?
There was a problem hiding this comment.
it's the nested img element:
<i-amphtml-sizer class="i-amphtml-sizer">
<img alt="" aria-hidden="true" class="i-amphtml-intrinsic-sizer" role="presentation" src="data:image/svg+xml;charset=utf-8,<svg height="100" width="300" xmlns="http://www.w3.org/2000/svg" version="1.1"/>">
</i-amphtml-sizer>
jridgewell
approved these changes
Aug 9, 2019
|
@jridgewell can you please merge as well. |
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* Make "layout=intrinsic" compatible with SSR Handles resize events by setting intrinsic layout's img src to ''. This does not include validator updates to support the intrinsic sizer. Fixes ampproject#17686 * change variable name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles resize events by setting intrinsic layout's img src to ''. This
does not include validator updates to support the intrinsic sizer.
Fixes #17686