-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "layout=intrinsic" compatible with SSR and handle resize events #17686
Comments
@aghassemi I may be able to take this depending on other workload and what the timing of SSR for |
This issue hasn't been updated in awhile. @aghassemi Do you have any updates? |
I've started looking into this for AMP Optimizer (and to unblock SSR for WP). What's the problem with resize events?
|
He's talking about Line 691 in 2246723
|
Handles resize events by setting intrinsic layout's img src to ''. This does not include validator updates to support the intrinsic sizer. Fixes ampproject#17686
Handles resize events by setting intrinsic layout's img src to ''. This does not include validator updates to support the intrinsic sizer. Fixes ampproject#17686
* Make "layout=intrinsic" compatible with SSR Handles resize events by setting intrinsic layout's img src to ''. This does not include validator updates to support the intrinsic sizer. Fixes #17686 * change variable name
* Make "layout=intrinsic" compatible with SSR Handles resize events by setting intrinsic layout's img src to ''. This does not include validator updates to support the intrinsic sizer. Fixes ampproject#17686 * change variable name
Need to update https://github.com/ampproject/amphtml/blob/master/src/custom-element.js#L613-L617 to handle SSR'd elements with
instrinsic
layout.Need to ensure that resize events correctly update the sizing scaling SVG at
https://github.com/ampproject/amphtml/blob/master/src/custom-element.js#L691
The text was updated successfully, but these errors were encountered: