Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Add missing return types in build-system/ #23749

Merged
merged 2 commits into from
Aug 7, 2019
Merged

🏗 Add missing return types in build-system/ #23749

merged 2 commits into from
Aug 7, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Aug 6, 2019 •
edited
Loading

This PR adds missing @return types to build-system/. Unlike runtime code, these are not type checked, and are merely for documentation.

Partial fix for #23582
Partial fix for #19767

@rsimha rsimha self-assigned this Aug 6, 2019
@erwinmombay
Copy link
Member

minor nits, so i approved ahead of times

@rsimha
Copy link
Contributor Author

rsimha commented Aug 7, 2019

All comments addressed. Thanks for the review!

@rsimha rsimha merged commit 21c6804 into ampproject:master Aug 7, 2019
@rsimha rsimha deleted the 2019-08-06-BuildSystemReturnTypes branch August 7, 2019 03:08
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
@rsimha
🏗 Add missing return types in build-system/ (ampproject#23749)
cc4c6a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwinmombay erwinmombay erwinmombay approved these changes

@danielrozenberg danielrozenberg Awaiting requested review from danielrozenberg

@estherkim estherkim Awaiting requested review from estherkim

Assignees

@rsimha rsimha

Labels
cla: yes WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsimha @erwinmombay @googlebot