Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing @return types across AMP code #23582

Closed
rsimha opened this issue Jul 29, 2019 · 1 comment
Closed

Add missing @return types across AMP code #23582

rsimha opened this issue Jul 29, 2019 · 1 comment
Labels
Stale Inactive for one year or more Type: Bug WG: access-subscriptions WG: analytics WG: monetization WG: performance WG: runtime WG: stories

Comments

@rsimha
Copy link
Contributor

rsimha commented Jul 29, 2019 •
edited
Loading

There were several missing @return annotations in the AMP codebase. #23559 added a whole bunch of them, and inserted @return {*} placeholders for the rest.

This is a tracking bug, and can be closed when all missing return types are specified. See #23559 (review)
@rsimha rsimha mentioned this issue Jul 29, 2019
Merged
@rsimha rsimha changed the title Add missing @return annotations to AMP code Add missing @return types across AMP code Jul 29, 2019
@rsimha rsimha mentioned this issue Aug 6, 2019
Merged
@rsimha rsimha removed the WG: infra label Aug 14, 2019
@samouri samouri mentioned this issue Nov 26, 2019
Merged
@stale
Copy link

stale bot commented Feb 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Feb 4, 2021
@stale stale bot closed this as completed Feb 11, 2021
adamsilverstein added a commit to adamsilverstein/amphtml that referenced this issue Feb 19, 2021
@adamsilverstein
Added a missing return type to isDomainMatch_ (see ampproject#23582).
1a3a222
@adamsilverstein adamsilverstein mentioned this issue Feb 19, 2021
Merged
micajuine-ho pushed a commit that referenced this issue Feb 22, 2021
@adamsilverstein
🐛 Don't append linker for exact domain match, even if in domains. (#…
aee80a6 
…32100)

* Don't append linker for exact domain match, even if in `domains`.

* Add linker test with matching window host.

* Update linker docs.

* Linter fixes.

* Adjust tests.

* Improve host name mocking for test.

* Fix new test.

* Added a missing return type to isDomainMatch_ (see #23582).

* Clarify documentation and correct a couple of typos.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale Inactive for one year or more Type: Bug WG: access-subscriptions WG: analytics WG: monetization WG: performance WG: runtime WG: stories
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rsimha