🐛 AMP4Email: Deprecate amp-lightbox and amp-image-lightbox #23173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
approved these changes
Jul 3, 2019
|
Looks like no validator tests or documentation need updating so we should be good to go. |
Gregable
approved these changes
Jul 3, 2019
twifkak
added a commit
to twifkak/amphtml
that referenced
this pull request
Jul 9, 2019
Merged
twifkak
added a commit
that referenced
this pull request
Jul 9, 2019
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
…t#23173) * alias commit * Tweak deprecation message for amp-image-lightbox * Tweak deprecation message for amp-lightbox
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* cl/257092185 Revision bump for ampproject#23137 * cl/257092258 Revision bump for ampproject#23143 * cl/257092328 Revision bump for ampproject#22917 * cl/257092384 Revision bump for ampproject#23180 * cl/257092442 Revision bump for ampproject#23173 * cl/257092491 Revision bump for ampproject#23195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate amp-lightbox and amp-image-lighbox in the AMP4EMAIL spec.
#23170
@choumx @fstanis