-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMP4Email: Invalidate amp-lightbox and amp-image-lightbox #23170
Comments
I know the original Pinterest demo AMP email shown below used |
lightboxes are useful to easily display additional information without asking the user to leave the email (product details for exemple). They are also useful to display forms (user profile for exemple) |
Today I saw a warning on the https://amp.gmail.dev/playground/ Maybe you will save amp-image-lightbox after all? Such functionality would be useful to me. |
It's the same for amp-sidebar? |
Are you planning on deprecating this anytime soon. We are using amp-lightbox component in production, if there is any definite timeline for deprecating this . cc @choumx |
Another fine example other than Pinterest demo AMP email is one we have in production. can you please have a look at how useful the lightbox can be. |
We're reconsidering this decision. Pending a design for better UX for handling lightboxes in a threaded email conversation view. |
Hi, we are currently developing an instant messaging service using amp-lightbox. can you suggest an alternative to amp-lightbox in this use case? |
There's currently no alternative. |
amp-lightbox and amp-image-lightbox don't make much sense because they occupy the full height of the document (email) and don't change their appearance based on the vertical size of the outer page nor the scroll position of the outer page.
#22297 is one example of this.
We have come up with no good solutions to this problem and so Gmail thinks we should disable these two components because there's no good way to use them at the moment.
The text was updated successfully, but these errors were encountered: