Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP4Email: Invalidate amp-lightbox and amp-image-lightbox #23170

Open
johnbarr opened this issue Jul 3, 2019 · 9 comments
Open

AMP4Email: Invalidate amp-lightbox and amp-image-lightbox #23170

johnbarr opened this issue Jul 3, 2019 · 9 comments
Labels
INTENT TO DEPRECATE Proposes deprecating an existing AMP feature. WG: amp4email

Comments

@johnbarr
Copy link
Contributor

johnbarr commented Jul 3, 2019

amp-lightbox and amp-image-lightbox don't make much sense because they occupy the full height of the document (email) and don't change their appearance based on the vertical size of the outer page nor the scroll position of the outer page.

#22297 is one example of this.

We have come up with no good solutions to this problem and so Gmail thinks we should disable these two components because there's no good way to use them at the moment.

@dreamofabear dreamofabear added WG: amp4email INTENT TO DEPRECATE Proposes deprecating an existing AMP feature. INTENT TO REMOVE Proposes removing a deprecated AMP feature. Use after the INTENT TO DEPRECATE. and removed Type: Bug INTENT TO DEPRECATE Proposes deprecating an existing AMP feature. labels Jul 3, 2019
@dreamofabear dreamofabear added INTENT TO DEPRECATE Proposes deprecating an existing AMP feature. and removed INTENT TO REMOVE Proposes removing a deprecated AMP feature. Use after the INTENT TO DEPRECATE. labels Jul 3, 2019
@bburbach
Copy link

I know the original Pinterest demo AMP email shown below used amp-lightbox to show more detail on clicked items. And we were evaluating some use cases that do something similar.
https://www.youtube.com/watch?v=Ghx9uxvusrE

@fabienbrouillaud
Copy link

lightboxes are useful to easily display additional information without asking the user to leave the email (product details for exemple). They are also useful to display forms (user profile for exemple)

@kristoferbaxter kristoferbaxter changed the title AMP4Email: blacklist amp-lightbox and amp-image-lighbox AMP4Email: denylist amp-lightbox and amp-image-lighbox Jul 30, 2019
@alexandr-kazakov
Copy link
Contributor

Today I saw a warning on the https://amp.gmail.dev/playground/
chrome_2019-08-01_17-34-42
http://bit.ly/2SVPZoK

Maybe you will save amp-image-lightbox after all? Such functionality would be useful to me.

@Nerone95
Copy link

It's the same for amp-sidebar?

@dreamofabear dreamofabear changed the title AMP4Email: denylist amp-lightbox and amp-image-lighbox AMP4Email: Invalidate amp-lightbox and amp-image-lightbox Sep 18, 2019
@modernwarfareuplink
Copy link

modernwarfareuplink commented Mar 4, 2020

Are you planning on deprecating this anytime soon. We are using amp-lightbox component in production, if there is any definite timeline for deprecating this . cc @choumx

@modernwarfareuplink
Copy link

Another fine example other than Pinterest demo AMP email is one we have in production. can you please have a look at how useful the lightbox can be.

@dreamofabear
Copy link

We're reconsidering this decision. Pending a design for better UX for handling lightboxes in a threaded email conversation view.

@neonithinar
Copy link

Hi, we are currently developing an instant messaging service using amp-lightbox. can you suggest an alternative to amp-lightbox in this use case?
PS I am just a beginner any tips and suggestions are heartily appreciated

@zhangsu
Copy link
Member

zhangsu commented Mar 23, 2023

There's currently no alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTENT TO DEPRECATE Proposes deprecating an existing AMP feature. WG: amp4email
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants