amp-list: Require reset-on-refresh="always" for local data #17221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
approved these changes
Jul 31, 2018
|
/cc @honeybadgerdontcare FYI validator change. |
Codecov Report
@@ Coverage Diff @@
## master #17221 +/- ##
==========================================
- Coverage 77.84% 77.83% -0.01%
==========================================
Files 562 562
Lines 41168 41168
==========================================
- Hits 32046 32043 -3
- Misses 9122 9125 +3
Continue to review full report at Codecov.
|
aghassemi
pushed a commit
that referenced
this pull request
Aug 2, 2018
* Validator support for always|fetch. * Update example file.
Gregable
pushed a commit
that referenced
this pull request
Aug 6, 2018
Merged
Gregable
added a commit
that referenced
this pull request
Aug 6, 2018
- Emits a warning if JSON cannot be parsed #15888 - Add `amp-pan-zoom` to experimental format #17150 - Clarify `INLINE_STYLE_TOO_LONG` error message. - Enable the `amp-date-picker` `minimum-nights` attribute #17201, #17220 - `amp-list`: Require `reset-on-refresh="always"` for local data #17221 - `amp-3d-glt`: add attribute `clearColor` #17085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #17202. Tested locally.
Turns out that changing
reset-on-refreshbehavior to also apply to local data (#16840) is a breaking change due to content height change when removing old children. Make this behavior opt-in by requiringreset-on-refresh="always"./to @aghassemi