Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Enable the minimum-nights attribute #17201

Merged
merged 2 commits into from
Jul 31, 2018
Merged

✨Enable the minimum-nights attribute #17201

merged 2 commits into from
Jul 31, 2018

Conversation

cvializ
Copy link
Contributor

@cvializ cvializ commented Jul 30, 2018

@cvializ cvializ requested a review from aghassemi July 30, 2018 22:44
aghassemi
aghassemi approved these changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@aghassemi aghassemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cvializ Validator change? separate PR ok.

@codecov-io
Copy link

codecov-io commented Jul 31, 2018 •
edited
Loading

Codecov Report

Merging #17201 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17201      +/-   ##
==========================================
+ Coverage   77.87%    77.9%   +0.02%     
==========================================
  Files         562      562              
  Lines       41169    41169              
==========================================
+ Hits        32062    32073      +11     
+ Misses       9107     9096      -11
Flag Coverage Δ
#integration_tests 36.17% <ø> (+0.03%) ⬆️
#unit_tests 76.96% <ø> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85d8a86...15385c3. Read the comment docs.

@cvializ
Copy link
Contributor Author

cvializ commented Jul 31, 2018

Good catch, thanks!

@cvializ cvializ merged commit 30cc384 into ampproject:master Jul 31, 2018
Gregable pushed a commit that referenced this pull request Aug 6, 2018
cl/207338980 Revision bump for #17201
4ab47be
@Gregable Gregable mentioned this pull request Aug 6, 2018
Merged
Gregable added a commit that referenced this pull request Aug 6, 2018
@Gregable
Validator Rollup (#17313)
8edcb22 
- Emits a warning if JSON cannot be parsed #15888 
- Add `amp-pan-zoom` to experimental format #17150 
- Clarify `INLINE_STYLE_TOO_LONG` error message.
- Enable the `amp-date-picker` `minimum-nights` attribute #17201, #17220
- `amp-list`: Require `reset-on-refresh="always"` for local data #17221 
- `amp-3d-glt`: add attribute `clearColor` #17085
@cvializ cvializ mentioned this pull request Jun 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aghassemi aghassemi aghassemi approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cvializ @codecov-io @aghassemi @googlebot