Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Temporarily disable tests on Safari #14856

Merged
merged 2 commits into from
Apr 25, 2018
Merged

✅ Temporarily disable tests on Safari #14856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63dad74
Temporarily disable tests on Safari
rsimha Apr 24, 2018
bd55679
Make exit more robust
rsimha Apr 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions build-system/pr-check.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,13 +307,14 @@ const command = {
}
// Unit tests with Travis' default chromium
timedExecOrDie(cmd + ' --headless');
if (!!process.env.SAUCE_USERNAME) {
// A subset of unit tests on other browsers via sauce labs
cmd = cmd + ' --saucelabs_lite';
startSauceConnect();
timedExecOrDie(cmd);
stopSauceConnect();
}
// TODO(rsimha, #14856): Re-enable after debugging Karma disconnects.
// if (!!process.env.SAUCE_USERNAME) {
// // A subset of unit tests on other browsers via sauce labs
// cmd = cmd + ' --saucelabs_lite';
// startSauceConnect();
// timedExecOrDie(cmd);
// stopSauceConnect();
// }
},
runIntegrationTests: function(compiled) {
// Integration tests on chrome, or on all saucelabs browsers if set up
Expand Down
26 changes: 15 additions & 11 deletions build-system/tasks/runtime-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,12 @@ function getConfig() {
'SL_Chrome_latest',
'SL_Chrome_45',
'SL_Firefox_latest',
'SL_Safari_latest',
'SL_Safari_10',
'SL_Safari_9',
'SL_iOS_latest',
'SL_iOS_10_0',
// TODO(rsimha, #14856): Re-enable after debugging Karma disconnects.
// 'SL_Safari_latest',
// 'SL_Safari_10',
// 'SL_Safari_9',
// 'SL_iOS_latest',
// 'SL_iOS_10_0',
// TODO(rsimha, #14374): Re-enable these after upgrading wd.
// 'SL_Edge_latest',
// 'SL_IE_11',
Expand Down Expand Up @@ -371,17 +372,19 @@ function runTests() {
log(
red('ERROR:'),
yellow('Karma test failed with exit code ' + exitCode));
process.exitCode = exitCode;
self.emitAsync('exit');
}
// TODO(rsimha, 14814): Remove after Karma / Sauce ticket is resolved.
setTimeout(() => {
process.exit(exitCode);
}, 5000);
resolver();
}).on('run_start', function() {
if (argv.saucelabs || argv.saucelabs_lite) {
console./* OK*/log(green(
log(green(
'Running tests in parallel on ' + c.browsers.length +
' Sauce Labs browser(s)...'));
} else {
console./* OK*/log(green('Running tests locally...'));
log(green('Running tests locally...'));
}
}).on('run_complete', function() {
if (shouldCollapseSummary) {
Expand All @@ -392,7 +395,7 @@ function runTests() {
}).on('browser_complete', function(browser) {
if (shouldCollapseSummary) {
const result = browser.lastResult;
let message = '\n' + browser.name + ': ';
let message = browser.name + ': ';
message += 'Executed ' + (result.success + result.failed) +
' of ' + result.total + ' (Skipped ' + result.skipped + ') ';
if (result.failed === 0) {
Expand All @@ -401,7 +404,8 @@ function runTests() {
message += red(result.failed + ' FAILED');
}
message += '\n';
console./* OK*/log(message);
console./* OK*/log('\n');
log(message);
}
}).start();
return deferred.then(() => exitCtrlcHandler(handlerProcess));
Expand Down