Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run pre-build steps in travis.yml only when necessary #9928

Closed
rsimha opened this issue Jun 14, 2017 · 0 comments
Closed

Run pre-build steps in travis.yml only when necessary #9928

rsimha opened this issue Jun 14, 2017 · 0 comments
Assignees
@rsimha
Labels
P2: Soon WG: infra
Milestone
Sprint H1 June

Comments

@rsimha
Copy link
Contributor

rsimha commented Jun 14, 2017

Today, we run steps like connecting to sauce labs and installing percy on all build shards for all PRs. There's scope for reducing this by an order of magnitude, which will put less of a load on the services and marginally speed up the travis build cycle.
@rsimha rsimha self-assigned this Jun 14, 2017
@rsimha rsimha added this to the Sprint H1 June milestone Jun 14, 2017
This was referenced Jun 14, 2017
Merged
Merged
rsimha added a commit that referenced this issue Jun 16, 2017
@rsimha
Percy visual diffing of AMP pages served from localhost and using a l…
2939ecc 
…ocally built runtime (#9833)

This PR adds a ruby script that starts up a local server for the AMP runtime, loads a test page from it, and grabs a snapshot via Percy. This will run on master, like before.

Visual diffing for PRs depends on making encrypted Percy tokens available on for PRs on Travis, and will come up in a separate PR.

#9469
Fixes #9928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsimha rsimha

Labels
P2: Soon WG: infra
Projects
None yet
Milestone
Sprint H1 June
Development

No branches or pull requests
1 participant
@rsimha