Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make visual diff tests PR blocking in case of failures #9469

Closed
rsimha opened this issue May 22, 2017 · 1 comment
Closed

Make visual diff tests PR blocking in case of failures #9469

rsimha opened this issue May 22, 2017 · 1 comment
Assignees
@rsimha
Labels
WG: infra
Milestone
Sprint H1 June

Comments

@rsimha
Copy link
Contributor

rsimha commented May 22, 2017

No description provided.

@rsimha rsimha added this to the Sprint H2 May milestone May 22, 2017
@rsimha rsimha self-assigned this May 22, 2017
@rsimha rsimha removed the Blocked label May 22, 2017
@rsimha
Copy link
Contributor Author

rsimha commented May 22, 2017

Getting to this point will require a quota purchase on Percy, and infrastructure work to integrate results with GitHub.

@rsimha rsimha mentioned this issue May 22, 2017
Closed
@rsimha rsimha modified the milestones: Sprint H1 June, Sprint H2 May Jun 2, 2017
This was referenced Jun 9, 2017
Merged
Merged
Merged
rsimha added a commit that referenced this issue Jun 16, 2017
@rsimha
Percy visual diffing of AMP pages served from localhost and using a l…
2939ecc 
…ocally built runtime (#9833)

This PR adds a ruby script that starts up a local server for the AMP runtime, loads a test page from it, and grabs a snapshot via Percy. This will run on master, like before.

Visual diffing for PRs depends on making encrypted Percy tokens available on for PRs on Travis, and will come up in a separate PR.

#9469
Fixes #9928
@rsimha rsimha mentioned this issue Jun 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsimha rsimha

Labels
WG: infra
Projects
None yet
Milestone
Sprint H1 June
Development

No branches or pull requests
1 participant
@rsimha