Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Punch List] - Video in AMP #4154

Closed
17 of 29 tasks
aghassemi opened this issue Jul 21, 2016 · 21 comments
Closed
17 of 29 tasks

[Punch List] - Video in AMP #4154

aghassemi opened this issue Jul 21, 2016 · 21 comments

Comments

@aghassemi
Copy link
Contributor

aghassemi commented Jul 21, 2016

This is a tracker issue for related work planned for video enhancements in AMP.

@aghassemi aghassemi added this to the Next milestone Jul 21, 2016
@aghassemi aghassemi self-assigned this Jul 21, 2016
@aghassemi
Copy link
Contributor Author

@cramforce @rudygalfi @ericlindley-g Here is a rough punch list for video related work we need to do. Feel free to edit. I will spin off more Github issues as time comes for each task.

@rudygalfi
Copy link
Contributor

Note: This covers #3799.

@tomasvts
Copy link

There is no autoplay attribute propagation in chrome v53 android.
muted autoplay is only working on IOS in the last version 1475106123549 thanks to fixIOSCanplayEventForAutoplay_ method.

@aghassemi
Copy link
Contributor Author

@tomasvts We don't actually propagate the autoplay attribute and call play() manually (even in fixIOSCanplayEventForAutoplay_, autoplay attribute is removed afterwards).

Are you seeing autoplay not working in Android or iOS? (There is a bug with Chrome autoplay in 4G/LTE which is fixed by #5228 - will be in the next release)

@rudygalfi
Copy link
Contributor

@aghassemi Wondering if this list needs to be updated at all, particularly the amp-youtube parts?

@rbp15
Copy link

rbp15 commented Dec 5, 2016

Any more information on amp-video-iframe?

@aghassemi
Copy link
Contributor Author

@randallbpotter15 Not yet, that being said, amp-video-iframe is fairly simple to add but until the underlying video player implements it, it won't do anything. Is there a particular video-player that you like to embed using amp-video-iframe? Are you in control of the underlying player and able to implement the expected behaviour (e.g. receiving a postMessage and pausing/playing the video and sending messages back to parent frame on video events such as pause/play?).

@rbp15
Copy link

rbp15 commented Dec 5, 2016

@aghassemi We are currently using an iframe to serve our video player as we have "pre-roll" ad needs and event management for analytics. We are always interested to hear about potential upgrades to the amp video experience. We are in control of the underlying player, both from one we made to work on AMP to our in-house version here at CNN.

Would love to learn more etc.

@aghassemi
Copy link
Contributor Author

aghassemi commented Dec 5, 2016

@randallbpotter15 That's great! CNN's video player is a perfect candidate for amp-video-iframe as a generic amp-cnn-player does not make sense in AMP.

Having a compelling use-case and a partner to work with for the initial version of amp-video-iframe is precisely what we need to kick of the work on amp-video-iframe. I will start work on this soon under an experimental flag and I assume you have the interest and hopefully some cycles to implement and collaborate on the approach.

The video-interface API will evolve overtime, currently the API is focused on providing hooks for managing autoplay and other playback related UX features we like to implement it AMP (rather than, say, analytics). <amp-video> and <amp-youtube> currently implement the interface, some examples of AMP's autoplay UX can be found here and here. This is the sort of UX CNN can expect with <amp-video-iframe autoplay src="cnn.com/url"></amp> when implemented.

@rbp15
Copy link

rbp15 commented Dec 7, 2016

@aghassemi I'd be happy to check this out with you all. @jmadler and some others on the team have my contact information for here at CNN.

@matAtWork
Copy link

Is the nascent <amp-video-iframe> documented anywhere? We (dailymail) are also struggling with analytics, etc. (see #6234 (comment))

@aghassemi
Copy link
Contributor Author

aghassemi commented May 2, 2017

@matAtWork <amp-video-iframe> doesn't exist yet :) but planned. Please subscribe to #8524for updates.
For your analytics needs, a solution similar to your and my comments on #6234 (independent of <amp-video-iframe>) should work. Let's continue the discussion on #6234

@shimonenator
Copy link

@aghassemi wanted to add that CBS would also be interested in adapting <amp-video-iframe> and the video interface.

@aghassemi
Copy link
Contributor Author

/cc @ericlindley-g setting to P2

@wassgha
Copy link
Contributor

wassgha commented Jun 10, 2017

@aghassemi #6285 checks off amp-dailymotion on the list

@wassgha
Copy link
Contributor

wassgha commented Jun 20, 2017

Can we add Media Session API and fullscreen on landscape to the punch list?

@aghassemi
Copy link
Contributor Author

@wassgha done and added a few more items around start/end overlays and allowing amp-animation's timeline to be tied to video timeline (see comments on #8971 for background).

@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @aghassemi Do you have any updates?

@aghassemi
Copy link
Contributor Author

it's a tracker

@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @aghassemi Do you have any updates?

@cathyxz
Copy link
Contributor

cathyxz commented May 2, 2018

/cc @alanorozco for housekeeping? I think at least parts of this is now tracked elsewhere so I don't know if this is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants