Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video should go to fullscreen mode on orientation change into landscape #5380

Closed
aghassemi opened this issue Oct 3, 2016 · 3 comments
Closed

Comments

@aghassemi
Copy link
Contributor

aghassemi commented Oct 3, 2016

If a visible video with landscape aspect ratio is playing (autoplay or user-initiated) in the middle of the screen in portrait mode and user rotates device into landscape, it is a strong signal user wants immersive fullscreen and therefore video should automatically go into fullscreen mode.

We may want to put this behind a page-level config (ideally opt-out).

UX thoughts? @cramforce @rudygalfi @edlea-g

@aghassemi
Copy link
Contributor Author

aghassemi commented Oct 3, 2016

/cc @abeck000

@cramforce
Copy link
Member

Assuming the video is in portrait. We should do this only if major platforms such as FB and Snapchat do it.

@aghassemi
Copy link
Contributor Author

Added the aspect ration requirement to the description.

FB (Native): Doesn't do this for autoplay videos, user-played videos always go to fullscreen mode anyway, so this is not applicable for non-autoplay videos. Same with twitter.

FB(Web): Unlike native, videos do play inline but orientation change does nothing.

Snapchat(Native): All videos are immersive fullscreen to start with, so not applicable.

YouTube(Native): Does this in native app

YouTube(Web): Does NOT do it on mobile web (despite UI mimicking native)

Washington Post(Native): Landscape orientation change not event allowed.

so lots of different UX out there.

What we do here could be just an element-level attribute as well so authors can decide based on their content if it make sense to go to fullscreen on orientation change. Or we could just do this for fixed hero videos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants