Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero mode for video players #7510

Closed
4 tasks
aghassemi opened this issue Feb 13, 2017 · 10 comments
Closed
4 tasks

Hero mode for video players #7510

aghassemi opened this issue Feb 13, 2017 · 10 comments

Comments

@aghassemi
Copy link
Contributor

aghassemi commented Feb 13, 2017

hero attribute on video players enables the following UX behavior:

  • Video is moved to the top of the page with full bleed.
  • Video autoplays
  • Docking UX for the playing video Docking UX for video players #8088
  • Maybe preload hero videos as part of preconnect (if not too heavy)
    hero attribute should be implemented as mostly a syntax sugar that brings existing independent effects.
    We already support autoplay.
@jpettitt
Copy link
Contributor

Where did amp-fx-scrollbound suddenly spring from? Is there any design doc on the future of what sounds really useful feature for other scroll related things like showing a fixed mini-header/share bar when the main header scrolls off.

@jridgewell
Copy link
Contributor

Where did amp-fx-scrollbound suddenly spring from? Is there any design doc on the future of what sounds really useful feature for other scroll related things like showing a fixed mini-header/share bar when the main header scrolls off.

/cc @dvoytenko

@aghassemi
Copy link
Contributor Author

@jpettitt No design doc yet, but we did a hackaton on scroll-bound visual effects a while back ( you can see some of the work on this fork: https://github.com/ampproject/amphtml/commits/amp-scroll-sync, although the API will most likely change ).

Scroll-bound effects is back on our plate, current rough prioritization is to support a few named effects and later expose a generic framework for doing arbitrary transformation based on scrolling. To start, we plan to support:
1- parallax scrolling ( #1443 )
2- minimize-to-corner (this issue)
3- sticky & peekaboo headers (similar to browser address-bar or AMP viewer's header)
4- a generic framework for more advanced use-cases

If you have particular scroll-bound UX that you need, please let me know!
/cc @ericlindley-g

@jpettitt
Copy link
Contributor

#1 and #3 are both things we'd like. Peekaboo footers would be nice too (generic version of amp-sticky-ad)

@zhouyx
Copy link
Contributor

zhouyx commented Feb 15, 2017

FYI: As already found with amp-sticky-ad. In safari, swipe to dismiss won't work with element placed at the bottom of the page, and bottom navigation bar hidden.

@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @aghassemi Do you have any updates?

2 similar comments
@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @aghassemi Do you have any updates?

@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @aghassemi Do you have any updates?

@aghassemi
Copy link
Contributor Author

not prioritize

@stale
Copy link

stale bot commented Dec 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Dec 30, 2020
@stale stale bot closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants