-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hero mode for video players #7510
Comments
Where did amp-fx-scrollbound suddenly spring from? Is there any design doc on the future of what sounds really useful feature for other scroll related things like showing a fixed mini-header/share bar when the main header scrolls off. |
/cc @dvoytenko |
@jpettitt No design doc yet, but we did a hackaton on scroll-bound visual effects a while back ( you can see some of the work on this fork: https://github.com/ampproject/amphtml/commits/amp-scroll-sync, although the API will most likely change ). Scroll-bound effects is back on our plate, current rough prioritization is to support a few If you have particular scroll-bound UX that you need, please let me know! |
FYI: As already found with amp-sticky-ad. In safari, swipe to dismiss won't work with element placed at the bottom of the page, and bottom navigation bar hidden. |
This issue hasn't been updated in awhile. @aghassemi Do you have any updates? |
2 similar comments
This issue hasn't been updated in awhile. @aghassemi Do you have any updates? |
This issue hasn't been updated in awhile. @aghassemi Do you have any updates? |
not prioritize |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
hero
attribute on video players enables the following UX behavior:preload
hero videos as part of preconnect (if not too heavy)hero
attribute should be implemented as mostly a syntax sugar that brings existing independent effects.We already support
autoplay
.The text was updated successfully, but these errors were encountered: