Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of highlight AMP-compatible themes and plugins in network pages #6726

Merged
merged 3 commits into from
Nov 19, 2021

Conversation

dhaval-parekh
Copy link
Collaborator

@dhaval-parekh dhaval-parekh commented Nov 17, 2021

Summary

Fixes #6725
Related #2313

Installed Themes.

Before After
image image

Add New Theme.

Before After
image image

Add New Plugin (Populer Tab)

Before After
image image

Add New Plugin (AMP Compatible Tab)

Before After
image image

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@dhaval-parekh dhaval-parekh marked this pull request as ready for review November 17, 2021 08:55
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2021

Plugin builds for 2e34795 are ready 🛎️!

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #6726 (1128bc7) into develop (9069888) will increase coverage by 0.71%.
The diff coverage is 100.00%.

❗ Current head 1128bc7 differs from pull request most recent head 2e34795. Consider uploading reports for the commit 2e34795 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #6726      +/-   ##
=============================================
+ Coverage      77.12%   77.83%   +0.71%     
- Complexity      6553     6556       +3     
=============================================
  Files            262      200      -62     
  Lines          20884    19783    -1101     
=============================================
- Hits           16107    15399     -708     
+ Misses          4777     4384     -393     
Flag Coverage Δ
javascript ?
php 77.83% <100.00%> (+<0.01%) ⬆️
unit 77.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Admin/AmpPlugins.php 100.00% <100.00%> (ø)
src/Admin/AmpThemes.php 100.00% <100.00%> (ø)
...k-validation/components/error/error-panel-title.js
...lidation/components/amp-validation-status/index.js
assets/src/common/helpers/index.js
...mes-context-provider/use-normalized-themes-data.js
assets/src/components/svg/reader.js
...s/src/components/options-context-provider/index.js
...sets/src/onboarding-wizard/components/nav/index.js
assets/src/components/amp-setting-toggle/index.js
... and 54 more

@westonruter westonruter added this to the v2.2 milestone Nov 17, 2021
Copy link
Collaborator

@delawski delawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. I also verified that the AMP compatible labels have been added to themes and plugins on a multisite install.

I left one minor comment in the code.

src/Admin/AmpThemes.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@milindmore22 milindmore22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@westonruter westonruter merged commit 2e31d81 into develop Nov 19, 2021
@westonruter westonruter deleted the bug/6725-highlight-amp-theme-plugin-in-mu-sites branch November 19, 2021 20:07
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlighting AMP-compatible themes and plugins in network theme/plugin screens is not working properly.
4 participants