-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight themes and plugins that are AMP-compatible inside WordPress #2313
Comments
Excellent. Regarding the badges, would like to associate them to each of the there are three states regarding AMP compatibility: AMP Compatible (green AMP badge), non-AMP compatible (red AMP badge), unknown AMP compatibility (gray AMP badge). |
We may need to add a REST API endpoint to query the list of themes and plugins that are AMP-compatible from amp-wp.org. |
There currently is https://amp-wp.org/wp-json/wp/v2/ecosystem |
It would be great if there was a way for users to opt-in to submit their validation errors to an aggregation service. Each time a URL is validated, the list of active themes and plugins can be sent along with any validation errors that were present. The aggregation service can then learn from the submissions which plugins and themes are AMP-incompatible, while at the same time infer which themes and plugins are AMP-compatible by noting X number of sites have them active but no validation errors are reported for them. |
This seems related to prior discussions on |
Having the database of AMP-compatible/incompatible plugins will be useful in the plugin suppression UI as well (see #4477 via #4657). With that, plugins could be categories into 4 sets:
To properly identify plugins in the 4th category, we'd ideally have the database of plugins. This would also provide the ability to highlight plugins in category 3 which are likely to cause validation errors. If we merge the categories into 2 sets we have:
So there are two supersets, with two sets inside each. At the moment the problematic plugins set is differentiated into two by which are checked and which are unchecked. In the unproblematic plugins set, there is no differentiation between the two subsets (known good vs unknown), currently. The database would provide us the ability to provide that differentiation. |
Update: We'll just omit showing any plugins which are not causing any validation errors at all. |
As discussed, we could also add a page under the AMP settings, and reference it, where we list out compatible extensions. |
Another integration point to highlight AMP-compatible themes is the Reader theme picker: #5678. |
The design for this is ready for engineering review and followup. Feel free to reach out with any questions! Plugin compatibility
Theme compatibility
Plugin list
Theme list Optional: Onboarding Please let me know if there are any questions! cc @westonruter, @dhaval-parekh, and @delawski (taking a guess with these initial folks, since we haven't decided who will pick this up) Link to Figma: https://www.figma.com/file/SfMlDvHc5KHxJmAZN12PIM/?node-id=2649%3A18194 |
Note in this context we can also include plugins that are not on WordPress.org. We just wouldn't be able to offer installation from that screen. We wouldn't be able to offer the same in the search results.
What about "PX Verified" instead? That seems a bit more clear.
Ditto for my comments above about plugins.
I wonder if this maybe too much? Maybe there could be a "PX Verified" comment tucked in with the plugin meta items, in the same line after the version and author are shown.
How would this look since themes are not listed in a list table but are rather presented as cards. I guess similar to browsing themes in the directory to install?
I don't think this is necessary because only AMP-compatible themes are offered as Reader themes in the first place. |
Good call out! cc @delawski
@amedina what do you think?
Good point. We could go with just the text; or try to make the design a little more subtle:
Yes I am thinking it would look the same as the theme directory.
Good point. |
Yes, and I think it can be shortened a bit more to just “PX Verified” here too. The text “Page Experience Enhancing” feels too verbose. |
@dhaval-parekh is picking up this issue to work on the recently updated implementation brief, while in the meantime the design gets finalised/updated by this week. |
@jwold , @westonruter Could we remove the rating, active install part from the plugin card that is not listed in WordPress org? Since, that information is not available in amp-wp.org and showing that information will be misleading. |
Currently the plugin has a short paragraph directing users to the ecosystem page on amp-wp.org before the list of template modes (#2135):
This is a good start but it's not integrated into the admin screens for installing themes and plugins.
Add new default tabs on the “Add New” theme/plugin screens for “AMP-compatible”, when in
Native/Transitional modes. This should selected instead of “Featured” because it's important to surface themes/plugins that actually work with AMP.
In addition, when searching for themes/plugins we could intercept the installation/activation action to show a warning whether or not it is known to be AMP-compatible.
Lastly, themes/plugins being listed could have an AMP badge for those known to be compatible. Also, for those which we know are not compatible, there could similarly be a warning badge, but this would require for us to maintain a list of incompatible plugins. For other themes and plugins which have an unknown compatibility status, there should be some message to indicate this.
Implementation Brief
The text was updated successfully, but these errors were encountered: