Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle plugins that cause validation errors #4477

Closed
amedina opened this issue Mar 31, 2020 · 0 comments · Fixed by #4657, #4889 or #5009
Closed

Gracefully handle plugins that cause validation errors #4477

amedina opened this issue Mar 31, 2020 · 0 comments · Fixed by #4657, #4889 or #5009
Labels
Changelogged Whether the issue/PR has been added to release notes. RME Reader Mode Expansion UX WS:UX Work stream for UX/Front-end
Milestone

Comments

@amedina
Copy link
Member

amedina commented Mar 31, 2020

In either Transitional mode or Reader mode, when a given plugin causes a validation error, the user will be presented with the option to prevent the plugin from running on AMP pages:

  • A new section in the AMP plugin admin screen enabling users to specify which of the installed plugins can be deactivated during amp responses when in transitional or reader mode (plugin suppression)
  • Alternatively, the UI to deactivate plugins in AMP responses could be integrated into the plugin list table.
  • In Reader Mode, the AMP plugin will automatically remove invalid markup and will notify the user there is an issue with the plugin, and the administrator of the site highlighting the offending markup and plugin (same to be done for Transitional mode and Standard mode).
  • Provide assistance when encountering validation errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. RME Reader Mode Expansion UX WS:UX Work stream for UX/Front-end
Projects
None yet
3 participants