Add compat support for twentytwenty core theme #3403
Conversation
schlessera
added
Enhancement
schlessera
force-pushed
the
add/3342-twentytwenty-support
branch
from
b8b4d97 to
776b952
Compare
schlessera
force-pushed
the
add/3342-twentytwenty-support
branch
2 times, most recently
from
1f86538 to
5185ea4
Compare
|
I've finished building generic replacements for the "toggles" and "modals" that the theme provides. This now makes it functional and usable. There are still lots of fine-tuning issues left, but the bulk of the work seems to be done. |
schlessera
force-pushed
the
add/3342-twentytwenty-support
branch
from
7d53aab to
2738a5e
Compare
|
The "spacing discrepancies" mentioned above seem to be related to the
The For the surrounding I assume for now that this spacing is incorrectly calculated inside of |
|
It looks like the "broken The issue is caused by the cat picture in the So part of the cat is output as actual HTML tags to the browser, breaking the markup. |
|
@westonruter I couldn't find any tests for theme compat for previous themes? Do you want me to still invest the time to write tests for the remaining items (see #3403 (comment))? It will be quite a bit of work to build such a theme test from scratch, and it will probably not test much more then my current assumptions anyway, as I don't have visual regression testing at my disposal yet. So it might not be worth the effort for now, and would be better to get this into QA as quickly as possible? |
Co-Authored-By: Weston Ruter <[email protected]>
The `\b` regex notation matches hyphens. Co-Authored-By: Weston Ruter <[email protected]>
…pproject/amp-wp into add/3342-twentytwenty-support
… make it protected for now
westonruter
changed the title
…twentytwenty-support * 'develop' of github.com:ampproject/amp-wp: (73 commits) Mock HTTP request for Test_AMP_WordPress_TV_Embed_Handler Add test case Fix issues with image display (#3555) Fix infinite loop when uploading videos (#3553) Fix styling on remove button. (#3554) Test for XML processing instruction Undo over-eager rename of auto_accept_sanitization Rename auto-accept to accept-by-default Rename filter to amp_validation_error_auto_sanitized Fix jumping blocks when changing fonts (#3529) Update dependency browserslist to v4.7.1 (#3551) Make sure that isPageBlock always returns boolean. Fix and improve e2e tests. Remove unnessary check for block. Use shift over access first element of array. Use isPageBlock for cleaner code. Fix minor grammar issues Add docblock for `amp_is_sanitization_auto_accepted` filter Align arrows Update tests to use filter to set sanitization auto acceptance Make AMP_Validation_Manage::is_sanitization_auto_accepted() filterable ...
| @@ -1023,6 +1023,18 @@ static function() use ( $args ) { | |||
| right: calc(100% + 2rem); | |||
| } | |||
|
|
|||
| .admin-bar .menu-modal { | |||
| /* Use padding to shift down modal because amp-lightbox has top:0 !important. */ | |||
| padding-top: 32px; | |||
There was a problem hiding this comment.
Oh, I just noticed I stored this in my browser, but not in the PR...
Have to watch out for this next time, I thought it was fixed.
There was a problem hiding this comment.
Oh, how did you store it in your browser?
There was a problem hiding this comment.
Adds support for the new
twentytwentycore theme that will be part of WordPress 5.3.Changes and todo:
'twentytwenty-js''wp_head'seems to be an upstream bug: <figure> element wrapping an <amp-img> element is mis-sized amphtml#25032- not a bug, can be fixed by addingdisplay: blockto the image, see <figure> element wrapping an <amp-img> element is mis-sized #3493 (comment)Fix video scaling discrepancy (screenshot)- unable to replicate with latest theme codeFix full-width embeds (screenshot)=> fixed via Full width iframes havelayout=intrinsicby default #3506Fix broken- see Add compat support for twentytwenty core theme #3403 (comment)<pre>tag (screenshot)Fix footer area (screenshot)- seems to have been an issue with the non-AMP versionFix WordPress.TV embed adding videopress iframe custom JS script (screenshot)=> fixed via WordPress TV embed includes custom script #3508Fix admin bar offset on mobile (screenshot)=> fixed via Gap at top of page for Admin Bar on mobile viewport (max-width:600px) #3436aria-expandedto toggle stateTwitter embed looks different, but seems broken in non-AMP instead (?) (screenshot)- see Add compat support for twentytwenty core theme #3403 (comment):focus-within)Fixes #3342.