Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with image display #3555

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Fix issues with image display #3555

merged 1 commit into from
Oct 18, 2019

Conversation

miina
Copy link
Contributor

@miina miina commented Oct 18, 2019 •
edited
Loading

Summary

Fixes #3429

  • Fix issues with image positioning.
  • Uses display: block for images in the FE.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@miina
Fix issues with image positioning.
70e6de0 
Use display:block for figure element.
@googlebot googlebot added the cla: yes Signed the Google CLA label Oct 18, 2019
@miina miina requested review from swissspidy and barklund October 18, 2019 13:39
swissspidy
swissspidy approved these changes Oct 18, 2019
View reviewed changes
Copy link
Collaborator

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@swissspidy swissspidy added this to the v1.4 milestone Oct 18, 2019
@swissspidy swissspidy merged commit 7ecb74a into develop Oct 18, 2019
@swissspidy swissspidy deleted the fix/3429-fix_image_display branch October 18, 2019 13:51
westonruter added a commit that referenced this pull request Oct 18, 2019
@westonruter
Merge branch 'develop' of github.com:ampproject/amp-wp into add/3342-…
ab98bab 
…twentytwenty-support

* 'develop' of github.com:ampproject/amp-wp: (73 commits)
  Mock HTTP request for Test_AMP_WordPress_TV_Embed_Handler
  Add test case
  Fix issues with image display (#3555)
  Fix infinite loop when uploading videos (#3553)
  Fix styling on remove button. (#3554)
  Test for XML processing instruction
  Undo over-eager rename of auto_accept_sanitization
  Rename auto-accept to accept-by-default
  Rename filter to amp_validation_error_auto_sanitized
  Fix jumping blocks when changing fonts (#3529)
  Update dependency browserslist to v4.7.1 (#3551)
  Make sure that isPageBlock always returns boolean.
  Fix and improve e2e tests.
  Remove unnessary check for block. Use shift over access first element of array.
  Use isPageBlock for cleaner code.
  Fix minor grammar issues
  Add docblock for `amp_is_sanitization_auto_accepted` filter
  Align arrows
  Update tests to use filter to set sanitization auto acceptance
  Make AMP_Validation_Manage::is_sanitization_auto_accepted() filterable
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

@barklund barklund Awaiting requested review from barklund

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Image Not Rendering Properly on Mobile and Desktop
3 participants
@miina @swissspidy @googlebot