Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @wordpress/server-side-render to v1.2.0 #3138

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Aug 29, 2019

This PR contains the following updates:

Package Type Update Change
@wordpress/server-side-render devDependencies minor 1.1.0 -> 1.2.0

Release Notes

WordPress/gutenberg

v1.2.0

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes Signed the Google CLA label Aug 29, 2019
swissspidy
swissspidy previously approved these changes Aug 29, 2019
Copy link
Collaborator

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swissspidy swissspidy added this to the v1.3 milestone Aug 29, 2019
@renovate-bot renovate-bot force-pushed the renovate/wordpress-server-side-render-1.x branch 2 times, most recently from bebd789 to 3f937c7 Compare August 29, 2019 17:24
@swissspidy swissspidy self-assigned this Aug 29, 2019
@swissspidy swissspidy self-requested a review August 29, 2019 17:50
@swissspidy swissspidy dismissed their stale review August 29, 2019 17:50

Looks like there are some actual test failures

@swissspidy
Copy link
Collaborator

WordPress/gutenberg#16133 broke things apparently 😞

@renovate-bot renovate-bot force-pushed the renovate/wordpress-server-side-render-1.x branch from 3f937c7 to b3ef819 Compare August 30, 2019 11:23
@swissspidy
Copy link
Collaborator

We're polyfilling wp.serverSideRender in case someone is using the Latest Stories block without using up-to-date Gutenberg (because it used to be in wp.components before). The code for that is very straightforward:

import * as serverSideRender from '@wordpress/server-side-render';
window.wp = window.wp || {};
window.wp.serverSideRender = serverSideRender;

@wordpress/server-side-render itself shims window.wp.components.ServerSideRender and emits a deprecated call in case anyone should access that.

However, this now causes issues with our Babel transpiling.

To reproduce:

  1. Checkout this branch / update the package
  2. Build plugin
  3. Make sure Gutenberg is not active
  4. Visit block editor
  5. See error

@barklund @miina Any ideas regarding this?

@barklund
Copy link
Contributor

  1. Checkout this branch / update the package

This branch, right?

  1. Build plugin
  2. Make sure Gutenberg is not active
  3. Visit block editor
  4. See error

Which error is that exactly?

I'm not sure my local setup is 100% correct, but I "only" see an error about Warning: Unsafe lifecycle methods were found within a strict-mode tree.

Can you help me replicate the issue?

@swissspidy
Copy link
Collaborator

Okay I am failing to replicate now 🤦‍♂ but it was this error:

TypeError: Cannot set property ServerSideRender of #<Object> which has only a getter
      at Module.<anonymous> (../../http:/localhost:8890/wp-content/plugins/amp/assets/js/wp-server-side-render.js?ver=1.2.3-alpha:3:689)
      at n (../../http:/localhost:8890/wp-content/plugins/amp/assets/js/wp-server-side-render.js?ver=1.2.3-alpha:1:110)
      at ../../http:/localhost:8890/wp-content/plugins/amp/assets/js/wp-server-side-render.js?ver=1.2.3-alpha:1:902
      at ../../http:/localhost:8890/wp-content/plugins/amp/assets/js/wp-server-side-render.js?ver=1.2.3-alpha:1:912
      at Suite.it (specs/block-editor/amp-toggle.js:19:2)

@renovate-bot renovate-bot force-pushed the renovate/wordpress-server-side-render-1.x branch 3 times, most recently from 1d2c37a to b73af95 Compare September 2, 2019 09:20
@renovate-bot renovate-bot force-pushed the renovate/wordpress-server-side-render-1.x branch from b73af95 to f87419d Compare September 3, 2019 09:27
@swissspidy swissspidy closed this Sep 9, 2019
@forking-renovate
Copy link

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will now ignore this update (1.2.0). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate-bot renovate-bot deleted the renovate/wordpress-server-side-render-1.x branch September 9, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants