-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency @wordpress/server-side-render to v1.2.0 #3138
Update dependency @wordpress/server-side-render to v1.2.0 #3138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some new placeholder components have been added: https://github.com/WordPress/gutenberg/blob/02c5f3950dda05ffbba532d285e58be9232c0acf/packages/server-side-render/CHANGELOG.md
bebd789
to
3f937c7
Compare
Looks like there are some actual test failures
WordPress/gutenberg#16133 broke things apparently 😞 |
3f937c7
to
b3ef819
Compare
We're polyfilling amp-wp/assets/src/polyfills/wp-server-side-render.js Lines 4 to 8 in 60d5b75
However, this now causes issues with our Babel transpiling. To reproduce:
|
This branch, right?
Which error is that exactly? I'm not sure my local setup is 100% correct, but I "only" see an error about Can you help me replicate the issue? |
Okay I am failing to replicate now 🤦♂ but it was this error:
|
1d2c37a
to
b73af95
Compare
b73af95
to
f87419d
Compare
Renovate Ignore NotificationAs this PR has been closed unmerged, Renovate will now ignore this update (1.2.0). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened. |
This PR contains the following updates:
1.1.0
->1.2.0
Release Notes
WordPress/gutenberg
v1.2.0
Compare Source
Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "
rebase!
".🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.