Add deprecated call to wp.components.ServerSideRender; Remove some missed wp.components.ServerSideRender usages.

[jorgefilipecosta]

Description

Follow up from #15635.

In #15635 we kept the back-compatibility for usages of wp.components.ServerSideRender but we did not implement a deprecated call.

This PR adds the missing deprecated call.

How has this been tested?

I changed the archives block to use ServerSideRender from wp.components.
I verified the block works as expected, but a deprecated warning is thrown in the browser console.

[jorgefilipecosta]

This PR was updated to avoid arrow function usage, it should be ready.

[gziolo]

I'm a bit worried that this might not work in all cases. What if someone has a block which imports ServerSideRender from wp.components but never references wp-server-side-render as a dependency. It's a tough problem. I see that we expose ServerSideRender from wp.editor, so maybe we should attach this polyfill there without any guard clauses? Or even we could include it inside @wordpress/editor which is less likely to be used outside of WordPress.

[gziolo]

It looks like you still need to rebase this PR after I merged your other PR which updates import for ServerSideRender.

[jorgefilipecosta]

Hi @gziolo the PR was rebased.

[gziolo]

Can you import deprecated to ensure it's listed as a dependency of the module when generating deps file for WordPress?

[jorgefilipecosta]

PR updated 👍

[gziolo]

It's a bit unfortunate that this global variable starts with lowercase.

[gziolo]

I tested with the following change:

@@ -17,10 +17,10 @@ import {
        BlockControls,
        InspectorControls,
 } from '@wordpress/block-editor';
-import ServerSideRender from '@wordpress/server-side-render';
 
 const DEFAULT_MIN_ITEMS = 1;
 const DEFAULT_MAX_ITEMS = 10;
+const { ServerSideRender } = wp.components;
 
 class RSSEdit extends Component {
        constructor() {

which is the closest you can get when developing as plugin. It works perfectly fine and I can see deprecation message:

I can also see wp.components.ServerSideRender when using Web Console.

PR updated

[gziolo]

I noticed that PHP and JS linters are still unhappy. You will have to convince them this PR is ready to go :)