-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken tooltips on validation list tables #2149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixarntz I think this is actually being used, though #2148 appears may have broken them.
Admin pointers were being used for the tooltips in the validated URLs post list table:
As well as on the validation error taxonomy term list table:
In the amp-stories-redux
branch, clicking these now does nothing.
They are working in the develop
branch however.
Ultimately, as identified in #1479 we need to eliminate the use of pointers altogether for this purpose.
@felixarntz Could you use this PR to fix the pointers broken in #2148?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixarntz I don't think these changes are right. I think it is this code that should be restored:
add_action( 'admin_enqueue_scripts', array( $this, 'register_tooltips' ) ); |
amp-wp/includes/admin/class-amp-admin-pointer.php
Lines 79 to 99 in 9d263d6
/** | |
* Registers style and script for tooltips. | |
* | |
* @since 1.0 | |
*/ | |
public function register_tooltips() { | |
wp_register_style( | |
self::TOOLTIP_SLUG, | |
amp_get_asset_url( 'css/' . self::TOOLTIP_SLUG . '.css' ), | |
array( 'wp-pointer' ), | |
AMP__VERSION | |
); | |
wp_register_script( | |
self::TOOLTIP_SLUG, | |
amp_get_asset_url( 'js/' . self::TOOLTIP_SLUG . '.js' ), | |
array( 'jquery', 'wp-pointer' ), | |
AMP__VERSION, | |
true | |
); | |
} |
This code is in develop
and 1.1
so no need to milestone the changes for 1.1.1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, since we have to revisit this anyway in #1479 it seems fine to just go ahead and merge this now.
No longer used. The dependencies do not actually depend on it.