Introduce admin pointers for AMP Stories #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em to create them.
westonruter
approved these changes
Apr 18, 2019
|
This introduced a regression. See #2149 (review) |
swissspidy
added a commit
that referenced
this pull request
May 21, 2019
The file is not needed since #2148, where this JS was added inline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new admin pointers:
As with all admin pointers, they both can be permanently dismissed on a per-user basis. Since we now have multiple notices, two new classes are introduced and replace the previously used class for the old admin pointer (the class code was pretty much taken from Site Kit).