-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add single error url page #1418
Merged
Merged
Changes from 17 commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
e616a08
Begin prototype for single error URL post.php page
kienstra f809c3d
Output a search box, though it will need to move above the 'Status' box
kienstra 469d3d2
Refactor simple anonymous function into method with PHPUnit test
kienstra 93b4f26
Create method get_terms_per_page()
kienstra d91786d
Add a unit test for parse_post_php_term_query()
kienstra 96141eb
Remove print_validation_errors_meta_box(), though might borrow some l…
kienstra 7d501f0
Move template list table into method
kienstra 500a6f5
Add unit test for render_single_url_list_table
kienstra 9446f68
Merge branch 'develop' into add/1365-single-error-url
kienstra 37e29f6
Reorder methods, add example URLs to DocBlock
kienstra 9adc5d4
Output the error type in that column
kienstra 67955cb
Allow filtering the single error page by type
kienstra b8d8459
Add the <tr> with 'Showing 4 of x validation errors' at the top of th…
kienstra e8e7906
Use dynamic values and translated text for the 'Showing errors' text
kienstra 2473214
If there are no errors to show, do not display this message
kienstra 838c393
Allow searching for errors
kienstra 6324b34
Minor DocBlock improvements
kienstra aef6e05
Instead of adding the taxonomy as a query var, add it to $_REQUEST
kienstra 9aaffdf
Correct failed unit test, updating with latest change
kienstra 834b141
Remove PHP logic for displaying search term(s), change number of post…
kienstra c4ed164
Remove PHP logic to support filtering and searching
kienstra 4a1e7f0
Filter the errors by type, using JavaScript
kienstra a552168
Address Travis error by removing empty line
kienstra 3fe3ffa
Match text formatting of the desings for the 'Error' and 'Details' co…
kienstra d9c7113
Apply the design for the link at the top of the page
kienstra 67530a4
Move 'Last checked' UI above 'Recheck' button
kienstra af06e79
Move 'Last checked' UI lower, to match designs
kienstra b5c1fb9
Add <select> element in the status column, reusing previous <select> …
kienstra 0b02674
Merge branch 'develop' into add/1365-single-error-url
kienstra 66e3a6f
Merge in develop, resolve conflicts
kienstra 384be89
Change 'Identified' to 'New', update another unit test
kienstra fb57681
Remove the 'Apply Filter' button, and update the errors on simply cha…
kienstra 4a1e21c
Add and support 'Accept' and 'Reject' buttons for bulk actions
kienstra 9d301f2
Address the Travis error, by changing the class to Exception
kienstra ebddc40
Update styling for the 'Accept' and 'Reject' buttons
kienstra a364758
Use the 'Accepted' icon in the post meta box
kienstra 1a282b7
Merge branch 'develop' into add/1365-single-error-url
kienstra bca2650
Apply John's work with sortable columns
kienstra 589b92f
Add the callback that enables ordering to the single URL page
kienstra 7936fab
Change the page header to match the design
kienstra 2fa80f6
Merge branch 'develop' into add/1365-single-error-url
jacobschweitzer fbabf80
Single error URL page - add expanded details view
johnwatkins0 3ca22ee
Merge branch 'add/1365-single-error-url' of https://github.com/Automa…
johnwatkins0 6d9d60a
Fixes after merge and small style imnprovements
johnwatkins0 d4307a7
Reuse the existing logic to render the 'Sources' column
kienstra 5d52bf0
Apply existing styling to the 'Sources' column
kienstra b4d4d60
Apply the existing icons to the 'Status' column
kienstra 02bc366
Address failed Travis builds
kienstra 8edf16e
Display the 'AMP Enabled' status in the post meta box
kienstra 957bb3f
Improve styling of 'AMP enabled' icon
kienstra 9878448
Change the status icon as the user chooses a status from the <select>
kienstra 3d63291
Fix an issue in switching back to 'New' status
kienstra 8b2c568
Restore logic to 'Preview Changes'
kienstra f80b5e2
Merge branch 'develop' into add/1365-single-error-url
kienstra 1b4c43c
Remove a reference to the constant VALIDATION_DETAILS_NODE_NAME_QUERY…
kienstra 19fc70d
Implement inline actions, like 'Accept' and 'Reject'.
kienstra e09db3d
Edit some DocBlocks, remove dom-ready from webpack.config.js
kienstra 738f2ad
Implement a basic JS search for errrors, using the 'Details' column
kienstra bdf411e
Fix an issue in passing the wrong argument to handle_validation_error…
kienstra c8807bd
Use intval() in sanitization, check that ! empty()
kienstra 2d3f30e
Fix more escaping, like using intval()
kienstra 9cafbeb
Instead of a boolean flag, use an array of arguments
kienstra 4829932
Remove default argument value, add a check for ! event.target.value
kienstra 00c11dd
Move styling from JSS to CSS
kienstra 2c1c140
If all of the rows are showing, hide the notice
kienstra 4875775
Merge in develop, resolve merge conflict
kienstra 029b986
Add a 'Show all' button to display all errors
kienstra 0da5582
Output the sources is the expandable 'Error' section
kienstra e7b194f
Address Travis error by moving parameter name 2 spaces to the right
kienstra 03cd2a8
On clicking 'Show all,' change the error type <select> to 'All Error …
kienstra 756b884
Change 'Reject' icon to red
kienstra 9074772
Only display the 'Accept' and 'Reject' bulk action buttons if a check…
kienstra 5965fee
Fix styling issue in 'Accept' and 'Reject' buttons, remove dead code
kienstra 731f313
Rename CSS file to reflect that it applies to the whole page
kienstra f2b62e8
Fix undefined index notices related to queried_object meta missing
westonruter 8e427d7
On clicking 'Show all', still show the notice with the count
kienstra 9db69ee
Prevent showing the 'Invalid URL' page header before it's overwritten…
kienstra b6695c3
Update Accept/Reject buttons to update select dropdown, not submit form.
westonruter 75f128f
When all of the errors are displaying, hide the notice
kienstra 505a42e
Because the show all button might be newly created, do a new query fo…
kienstra 2ba31f9
Fix presentation of toggle button in narrower screen resolutions
westonruter 818259e
Commit changes in order to merge remote
johnwatkins0 5f15604
Merge branch 'develop' of https://github.com/Automattic/amp-wp into a…
westonruter aa21e14
Single error view - add toggle all button for sources column
johnwatkins0 b28875c
Merge remote and resolve conflicts
johnwatkins0 5b7c2e0
Merge develop into add/1365-single-error-url
johnwatkins0 39cb830
Single error view - remove debug statement
johnwatkins0 f0668f7
Validation - tooltip fixes
johnwatkins0 da5169b
Validation - PHPCS fixes
johnwatkins0 3dce980
Validation - PHPCS fixes
johnwatkins0 8d603f4
Validation PHPUnit - restore removed line in test
johnwatkins0 d5b3a42
Don't show the 'Reject' and 'Accept' action links on the single URL p…
kienstra f0677bf
Set document title in addition to the heading
westonruter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally
amp-invalid-url-post-edit-screen.js
should be be made into an ES6 module likeamp-validation-single-error-url-details.js
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Do you think that should be done before merging this? Otherwise, maybe I could add this script to #1298.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, better to do as part of #1298.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I added this to #1298.