-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert block validation script to a module, and bundle it with block toggle module #1298
Comments
Hi @postphotos, This arose from the work on #1275 (comment). |
Thanks, @hellofromtonya! I'm not sure if I'll work on this issue soon, though. In the meantime, this is free for anyone to pick up. |
Adding Another Script To The Requirements Per this conversation, please also convert amp-invalid-url-post-edit-screen.js to an ES6 module. |
I'm going to close this because this will come automatically once we refactor the admin screens to use JS-driven interfaces as opposed to the PHP-driven ones we've largely tried to re-use from what WordPress provides. |
AC1. Convert amp-block-validation.js to an ES6 module
AC2. Create a new file that will
import
both this module and amp-block-editor-toggle.js (though that might have since been renamed). This can be similar to blocks/index.js.AC3. Add that new file with the
import
statements to webpack.config.js, so it will be compiled withnpm run dev
AC4. Ensure that the compiled files have sourcemaps.
This should probably wait for the work on
amp-block-validation.js
in #1293The text was updated successfully, but these errors were encountered: