Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing amp-ad ending tag #1135

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Add missing amp-ad ending tag #1135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .../transformers/valid/ServerSideRendering/transforms_layout_responsive/expected_output.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
<!-- Auto adds responsive attribute if height, width and sizes -->
<amp-ad class="i-amphtml-layout-responsive i-amphtml-layout-size-defined" type="taboola" data-block-on-consent="_till_responded" width="300" height="250" data-publisher="..." data-mode="thumbnails-a-amp" data-placement="Mobile Below Article Thumbnails AMP" data-article="auto" data-target_type="mix" layout="responsive" i-amphtml-layout="responsive">
<i-amphtml-sizer style="display:block;padding-top:83.3333%"></i-amphtml-sizer>
<!-- Auto adds responsive attribute if height, width and heights -->
<amp-ad class="i-amphtml-layout-responsive i-amphtml-layout-size-defined" type="taboola" data-block-on-consent="_till_responded" width="300" height="250" data-publisher="..." data-mode="thumbnails-a-amp" data-placement="Mobile Below Article Thumbnails AMP" data-article="auto" data-target_type="mix" layout="responsive" i-amphtml-layout="responsive" id="i-amp-0">
<i-amphtml-sizer style="display:block;padding-top:83.3333%"></i-amphtml-sizer>
</amp-ad>
</amp-ad>
<!-- Auto adds responsive attribute if height, width and heights -->
<amp-ad class="i-amphtml-layout-responsive i-amphtml-layout-size-defined" type="taboola" data-block-on-consent="_till_responded" width="300" height="250" data-publisher="..." data-mode="thumbnails-a-amp" data-placement="Mobile Below Article Thumbnails AMP" data-article="auto" data-target_type="mix" layout="responsive" i-amphtml-layout="responsive" id="i-amp-0">
<i-amphtml-sizer style="display:block;padding-top:83.3333%"></i-amphtml-sizer>
</amp-ad>
</body>
</html>
3 changes: 2 additions & 1 deletion ...mizer/spec/transformers/valid/ServerSideRendering/transforms_layout_responsive/input.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
data-article=auto
data-target_type=mix
>
</amp-ad>
<!-- Auto adds responsive attribute if height, width and heights -->
<amp-ad
class=""
Expand All @@ -34,6 +35,6 @@
data-article=auto
data-target_type=mix
>
</amp-ad>
</amp-ad>
</body>
</html>