Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing amp-ad ending tag #1135

Merged

Conversation

schlessera
Copy link
Collaborator

The input.html file in the ServerSideRendering/transforms_layout_responsive spec test is missing an ending tag for one of the <amp-ad> elements, which messes up the test output.

Copy link
Collaborator

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@sebastianbenz sebastianbenz merged commit 6e5f1f5 into ampproject:main Feb 3, 2021
@schlessera schlessera deleted the fix/missing-amp-ad-ending-tag branch February 4, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants