perf: Avoid an extra function call and object clone during event emis…

…sion (rrweb-io#1441) performance: remove a nested function call and an object clone during event emission - rename `event` to `eventWithoutTime`, but maintain backwards compatibility - `eventWithTime` (with time) could be renamed to `event` in a future version This is an extension of PR rrweb-io#1339 authored by: mydea <[email protected]>
amplitude · Jul 31, 2024 · ac71f04 · ac71f04
1 parent 21278b5
commit ac71f04
Show file tree

Hide file tree

Showing 5 changed files with 149 additions and 177 deletions.
diff --git a/.changeset/event-single-wrap.md b/.changeset/event-single-wrap.md
@@ -0,0 +1,5 @@
+---
+'rrweb': patch
+---
+
+perf: Avoid an extra function call and object clone during event emission
diff --git a/packages/rrweb/src/record/iframe-manager.ts b/packages/rrweb/src/record/iframe-manager.ts
@@ -1,6 +1,6 @@
 import type { Mirror, serializedNodeWithId } from '@amplitude/rrweb-snapshot';
 import { NodeType, genId } from '@amplitude/rrweb-snapshot';
-import type { eventWithTime, mutationCallBack } from '@amplitude/rrweb-types';
+import type { eventWithTime, eventWithoutTime, mutationCallBack } from '@amplitude/rrweb-types';
 import { EventType, IncrementalSource } from '@amplitude/rrweb-types';
 import type { CrossOriginIframeMessageEvent } from '../types';
 import CrossOriginIframeMirror from './cross-origin-iframe-mirror';
@@ -16,7 +16,7 @@ export class IframeManager {
     new WeakMap();
   private mirror: Mirror;
   private mutationCb: mutationCallBack;
-  private wrappedEmit: (e: eventWithTime, isCheckout?: boolean) => void;
+  private wrappedEmit: (e: eventWithoutTime, isCheckout?: boolean) => void;
   private loadListener?: (iframeEl: HTMLIFrameElement) => unknown;
   private stylesheetManager: StylesheetManager;
   private recordCrossOriginIframes: boolean;
@@ -26,7 +26,7 @@ export class IframeManager {
     mutationCb: mutationCallBack;
     stylesheetManager: StylesheetManager;
     recordCrossOriginIframes: boolean;
-    wrappedEmit: (e: eventWithTime, isCheckout?: boolean) => void;
+    wrappedEmit: (e: eventWithoutTime, isCheckout?: boolean) => void;
   }) {
     this.mutationCb = options.mutationCb;
     this.wrappedEmit = options.wrappedEmit;