Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install versions after 1.18.0 #531

Closed
tmsdce opened this issue Oct 24, 2023 · 16 comments
Closed

Can't install versions after 1.18.0 #531

tmsdce opened this issue Oct 24, 2023 · 16 comments
Labels
bug Something isn't working

Comments

@tmsdce
Copy link

tmsdce commented Oct 24, 2023

Prerequisites

  • Be sure that theres no open issue already.

Description

I can't install the latest version of the provider (1.18.3)

│ Error: Failed to install provider
│ 
│ Error while installing aminueza/minio v1.18.3: checksum list has no SHA-256 hash for
│ "https://github.com/terraform-provider-minio/terraform-provider-minio/releases/download/v1.18.3/terraform-provider-minio_1.18.3_linux_amd64.zip"

Steps to Reproduce

  1. Create a tf file with the following content
terraform {
  required_providers {
    minio = {
      source  = "aminueza/minio"
      version = "~> 1.18"
    }
  }
}
  1. Run terraform init

Expected behavior:

Provider installation should succeed

Actual behavior:

An error occurs

│ Error: Failed to install provider
│ 
│ Error while installing aminueza/minio v1.18.3: checksum list has no SHA-256 hash for
│ "https://github.com/terraform-provider-minio/terraform-provider-minio/releases/download/v1.18.3/terraform-provider-minio_1.18.3_linux_amd64.zip"

Reproduces how often: 100%

Versions

terraform: 1.5.7
provider: 1.18.3

Additional Information

The SHA256 checksum assets don't seem to be published with the release. It was the case in version 1.18.0 which works fine

@felladrin
Copy link
Collaborator

Thanks for letting us know!
Will double-check the release workflow.

@felladrin
Copy link
Collaborator

🤔 I see the shasum file is available at https://github.com/terraform-provider-minio/terraform-provider-minio/releases/tag/v1.18.3, and the shasum for terraform-provider-minio_1.18.3_linux_amd64.zip is there:

image

The published files in these release match the number of the files released in the previous one (v1.18.0).

@felladrin felladrin added the help wanted Extra attention is needed label Oct 24, 2023
@tmsdce
Copy link
Author

tmsdce commented Oct 24, 2023

You're right about the assets. I didn't catch them on the release page, sorry about that 😅
Still, install fails so there must be another reason

@felladrin
Copy link
Collaborator

Indeed.
I can't investigate deeper now, but I will do it soon.
Please keep me posted if you find out anything new about this issue.

[I doubt it, but this could be related to the repository address, which was changed recently.]

@larivierec
Copy link

Same with me, using terraform 1.6.2

@felladrin
Copy link
Collaborator

💡 I think the issue is really about the repository address. I checked the response of these two URLs:

And the shasums URL hasn't been updated.

Previous Current
image image

The sad thing is that there's no option in Terraform Registry provider settings to change the repository ULR of a released provider.

@felladrin
Copy link
Collaborator

Published v1.19.0, including #520, but the shasums_url continue pointing to the previous repo.
We'll contact HashiCorp support to check what can be done. (Databricks has been through the same process)

@tmsdce
Copy link
Author

tmsdce commented Oct 24, 2023

Thank you @felladrin
I'll stick to 1.18.0 for now as a temporary workaround

@felladrin felladrin added bug Something isn't working and removed help wanted Extra attention is needed labels Oct 25, 2023
@BuJo BuJo changed the title Can't install version 1.18.3 Can't install versions after 1.18.0 Oct 31, 2023
@felladrin
Copy link
Collaborator

Just to let you know that we're currently waiting for HashiCorp's support response on this.

@mrsimonemms
Copy link

We're finding the same issue but sticking with v1.18.0 has worked as a workaround.

@felladrin
Copy link
Collaborator

Alright, everyone, we got a detailed response from one of the engineers from the Terraform Registry team, and, in summary, there's no way to change the provider in the Registry (aminueza/minio) for it to use the repository under our new organization.

Click here for more details. Since the provider in the Registry is highly attached to the GitHub auth system (the namespace of the provider must match the GitHub owner), to publish new versions of the provider from this repository (https://github.com/terraform-provider-minio/terraform-provider-minio), it'd need to be done through an entirely new provider.

Considering the situation, and also all the users that rely on this provider, here's what's going to happen next:
We'll move the repository back under aminueza's GitHub account, update the GPG key and literal URLs in the code, and finally publish v1.20.0 in the registry, which won't suffer from the Failed to install provider issue anymore.

Extra info: We won't dissolve the github.com/terraform-provider-minio organization because it will be redirecting the traffic to aminueza's repo and also because it might be useful for forks/sibling repos later. The advantage of having an organization is that the maintainers have more autonomy over the repositories.

@larivierec
Copy link

If I may add my two cents, wouldn't it be easier to create a new gpg key and publish under the new repo name as well as the old repo for the first few patches/minors and eventually transition into just using the org one?

I'm no where near an expert and don't know if there are licensing fees and such but it seems like an idea.

Tl;dr;

Support both. publish for a bit (new + old) providers.

Deprecate the old provider and encourage people to transition to the new provider

Ending support/features/security updates at a set time for the old provider.

@felladrin
Copy link
Collaborator

felladrin commented Nov 4, 2023

Indeed! Forking/mirroring might happen later, considering we still have that other intricate issue to solve.
In all cases, the original repo has to be back in place for the current provider to get back working.
But one issue at a time🤞

@felladrin
Copy link
Collaborator

felladrin commented Nov 4, 2023

v1.20.0 published! 🎉

image image image image

@tmsdce
Copy link
Author

tmsdce commented Nov 6, 2023

Thanks for publishing a new release 👍
I can confirm that 1.20 is working fine.
Switching to a new repo/namespace in the future would be nice

@mrsimonemms
Copy link

Yeah, working for us as well. Thanks @felladrin

shosti pushed a commit to shosti/eevans-infra that referenced this issue Dec 3, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [minio](https://registry.terraform.io/providers/aminueza/minio) ([source](https://github.com/aminueza/terraform-provider-minio)) | required_provider | minor | `~> 1.18.0` -> `~> 1.20.0` |

---

> ⚠ **Warning**
>
> Some dependencies could not be looked up. Check the warning logs for more information.

---

### Release Notes

<details>
<summary>aminueza/terraform-provider-minio (minio)</summary>

### [`v1.20.1`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v1.20.1)

[Compare Source](aminueza/terraform-provider-minio@v1.20.0...v1.20.1)

#### What's Changed

-   Fix null expiration date handling by [@&#8203;pjsier](https://github.com/pjsier) in aminueza/terraform-provider-minio#545
-   Update terraform version to 1.5.7 in GitHub Action by [@&#8203;felladrin](https://github.com/felladrin) in aminueza/terraform-provider-minio#540

**Full Changelog**: aminueza/terraform-provider-minio@v1.20.0...v1.20.1

> **Note**
> [v1](https://github.com/aminueza/terraform-provider-minio/tree/v1) of the provider is now under maintenance mode. If you can, it's advised to upgrade to `v2`.

### [`v1.20.0`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v1.20.0)

[Compare Source](aminueza/terraform-provider-minio@v1.19.0...v1.20.0)

#### What's Changed

-   Update module github.com/aws/aws-sdk-go to v1.45.6 by [@&#8203;renovate](https://github.com/renovate) in aminueza/terraform-provider-minio#515
-   Update crazy-max/ghaction-import-gpg action to v6 by [@&#8203;renovate](https://github.com/renovate) in aminueza/terraform-provider-minio#516
-   Handle empty service account policy by [@&#8203;ArataEM](https://github.com/ArataEM) in aminueza/terraform-provider-minio#518
-   Go 1.20 by [@&#8203;BuJo](https://github.com/BuJo) in aminueza/terraform-provider-minio#519
-   Destroy object versions on bucket force_destroy by [@&#8203;pjsier](https://github.com/pjsier) in aminueza/terraform-provider-minio#524
-   Update goreleaser-action to v5 and add permission for the workflow to attach binaries to GitHub Releases by [@&#8203;felladrin](https://github.com/felladrin) in aminueza/terraform-provider-minio#521
-   Add Noncurrent Version expiration to ilm policy by [@&#8203;ndejesus](https://github.com/ndejesus) in aminueza/terraform-provider-minio#526
-   Bump golang.org/x/net from 0.15.0 to 0.17.0 by [@&#8203;dependabot](https://github.com/dependabot) in aminueza/terraform-provider-minio#530
-   Add service account values to read and import by [@&#8203;pjsier](https://github.com/pjsier) in aminueza/terraform-provider-minio#525
-   feat: recreate user if not found anymore by [@&#8203;tobikris](https://github.com/tobikris) in aminueza/terraform-provider-minio#534
-   Bump google.golang.org/grpc from 1.58.0 to 1.58.3 by [@&#8203;dependabot](https://github.com/dependabot) in aminueza/terraform-provider-minio#535

#### New Contributors

-   [@&#8203;ndejesus](https://github.com/ndejesus) made their first contribution in aminueza/terraform-provider-minio#526

**Full Changelog**: aminueza/terraform-provider-minio@v1.18.0...v1.20.0

> **Note**
> This release replaces v1.18.1 and v1.18.2, which are unavailable on https://registry.terraform.io/providers/aminueza/minio as they were built with an outdated GPG key. It also replaces v1.18.3 and v1.19.0, which couldn't be installed due the issue [#&#8203;531](aminueza/terraform-provider-minio#531).

### [`v1.19.0`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v1.19.0)

[Compare Source](aminueza/terraform-provider-minio@v1.18.3...v1.19.0)

Changes on this Release:

-   Update crazy-max/ghaction-import-gpg action to v6 ([#&#8203;516](aminueza/terraform-provider-minio#516))
-   Handle empty service account policy ([#&#8203;518](aminueza/terraform-provider-minio#518))
-   Update repository URL ([#&#8203;520](aminueza/terraform-provider-minio#520))
-   Destroy object versions on bucket force_destroy ([#&#8203;524](aminueza/terraform-provider-minio#524))
-   Add Noncurrent Version expiration to ilm policy ([#&#8203;526](aminueza/terraform-provider-minio#526))

**Full Changelog**: aminueza/terraform-provider-minio@v1.18.0...v1.19.0

> **Note**
> This release replaces v1.18.1 and v1.18.2, which are unavailable on https://registry.terraform.io/providers/aminueza/minio as they were built with an outdated GPG key. It also replaces v1.18.3, which couldn't be installed due the issue [#&#8203;531](aminueza/terraform-provider-minio#531).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4wIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Reviewed-on: https://gitea.eevans.me/shosti/eevans-infra/pulls/10
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants