Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump eslint peerDep to eslint@6 #243

Merged
merged 4 commits into from
Jun 26, 2019
Merged

bump eslint peerDep to eslint@6 #243

merged 4 commits into from
Jun 26, 2019

Conversation

amilajack
Copy link
Owner

No description provided.

@ljharb
Copy link
Collaborator

ljharb commented Jun 22, 2019

Make sure it’s added to CI too - if it’s not tested it’s not supported.

@amilajack
Copy link
Owner Author

Tests are passing with eslint@6 but linting doesn't pass because of the following error:

Error: Failed to load plugin 'import' declared in 'package.json » eslint-config-bliss » eslint-config-ai
rbnb-base » /.../node_modules/eslint-config-airbnb-base/
rules/imports.js': Cannot find module 'eslint/lib/util/source-code'
Require stack:

@ljharb
Copy link
Collaborator

ljharb commented Jun 23, 2019

That might need to wait on the next version of the import plugin being published.

@tbroyer
Copy link
Contributor

tbroyer commented Jun 25, 2019

eslint-plugin-import 2.18.0 has been released: https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md

@amilajack amilajack merged commit c0b791e into master Jun 26, 2019
@amilajack amilajack deleted the peer-deps-eslint-6 branch December 31, 2019 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants