Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-plugin-compat doesn't work on ESLint v6.0.0 #244

Closed
laukstein opened this issue Jun 23, 2019 · 4 comments
Closed

eslint-plugin-compat doesn't work on ESLint v6.0.0 #244

laukstein opened this issue Jun 23, 2019 · 4 comments

Comments

@laukstein
Copy link

laukstein commented Jun 23, 2019

After ESLint update to v6.0.0 https://github.com/eslint/eslint/releases/tag/v6.0.0, eslint-plugin-compat is no longer working, shows :

 Error     24,24: Promise is not supported in IE 11 (compat/compat)
 Error     66,24: Promise.reject() is not supported in IE 11 (compat/compat)
 Error     85,25: URLSearchParams is not supported in IE 11 (compat/compat)
 Error    118,36: Promise is not supported in IE 11 (compat/compat)
 Error    139,20: Promise.reject() is not supported in IE 11 (compat/compat)
 Error    147,26: URL is not supported in IE 11 (compat/compat)
 Error    163,26: URL is not supported in IE 11 (compat/compat)

while having in package.json :

"dependencies": {
    "babel-eslint": "^8.2.2",
    "browserslist": "^3.1.1",
    "eslint": "^4.18.2",
    "eslint-plugin-compat": "^2.2.0"
},
"browserslist": [
    "last 2 versions",
    "not < 0.25%",
    "not op_mini all",
    "not android 4.4.3"
],
"eslintConfig": {
    "settings": {
        "polyfills": [
            "AbortController",
            "Array.from",
            "BroadcastChannel",
            "document.currentScript",
            "fetch",
            "intersectionobserver",
            "navigator.maxTouchPoints",
            "navigator.serviceWorker",
            "Object.assign",
            "Object.entries",
            "Object.values",
            "Promise",
            "Proxy",
            "Reflect",
            "URL",
            "URLSearchParams"
        ]
    }
}

#242 might related issue.

@ljharb
Copy link
Collaborator

ljharb commented Jun 23, 2019

Does npm ls run successfully? If not, your dep graph is invalid, and you can't expect anything to work.

Prior to #242 being resolved, it is invalid to try to use eslint 6 with this project.

@laukstein
Copy link
Author

Ignore this, repo packages where outdated. I succeed to update it with :

ncu -u
npm install

and now it seems working fine.

@laukstein
Copy link
Author

@ljharb, npm ls shows

npm ERR! peer dep missing: eslint@^3.0.0 || ^4.0.0 || ^5.0.0, required by [email protected]

Any ETA to support on ESLint v6 ?

@amilajack
Copy link
Owner

#243 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants