Close Telemetry Server: subset B - Stop listening to client requests #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert 'handleTermination()' into a class for a better handling of
the multiple Promise/Resolve cycles.
- Create class 'TerminationHandler': main method 'HandleTermination.run()' starts the
termination.
- Former function 'handleTermination' body now defines 'HandleTermination.runSubsetA()'.
- Define 'WebsocketTracker.pauseAll()' which pauses all the open sockets.
- Use it for the server closure step B.
|
@S-Dafarra @RiccardoGrieco , I'm submitting small PRs because I assumed it would be easier for you guys to review in small time slots where you would have available time. Let me know if it wasn't a good idea. |
17 tasks
S-Dafarra
approved these changes
Oct 27, 2021
Closed
|
@RiccardoGrieco , although @S-Dafarra already approved, I'll wait for you to take a look at the changes. |
RiccardoGrieco
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements step B of #40 .
the multiple Promise/Resolve cycles.
termination.