-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pixi configuration #281
Conversation
ed7ac61
to
a36408e
Compare
Can you please check upon review if the current GPU configuration works on your setup? It seems that CUDA is detected and arrays can be allocated on GPUs, but then jax fails to jit-compile functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Diego! I would keep the CI name of pixi
e.g. drop 4d42133, as in the future we might think to use pixi
for running the tests on CI and it may create confusion
Reverting the name would be ok for me, just note that in this PR I also added a new step that runs the tests against the newly resolved pixi environment. For what regards CI/CD, I'd suggest to keep the functionality (regardless to the way dependencies are installed) in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @diegoferigo ! LGTM!
This is great, thanks!
Yes, it definitely makes sense to keep the two things in two separate workflows |
Great! I just need now someone that can confirm whether the resolved GPU environment fully works. I'm transitioning to a new setup and I don't have Nvidia GPUs available at the moment. |
I could solve the GPU environment with these modifications: diff --git a/pyproject.toml b/pyproject.toml
index 1be8b1d..bb4fa88 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -258,13 +258,12 @@ robot_descriptions = "*"
[tool.pixi.feature.gpu]
platforms = ["linux-64"]
-system-requirements = { cuda = "12.1" }
+system-requirements = { cuda = "12"}
[tool.pixi.feature.gpu.dependencies]
-cuda-version = "12.*"
cuda-nvcc-tools = "*"
cuda-nvvm-tools = "*"
-cudnn = "9.3.0.*"
+cudnn = "*"
# Pinning a specific version awaiting the following to get addressed:
# https://github.com/conda-forge/jaxlib-feedstock/issues/285
jaxlib = { version = "<0.4.32", build = "*cuda*" } |
Does the following work on your setup? On mine it doesn't:
|
Yes but I get some logs from PTXAS. It seems related to openxla/xla#16431 as I'm on CUDA 12.6: $ pixi run --environment gpu python -c "import jax.numpy as jnp; jnp.linalg.norm(jnp.ones(3))"
WARN The feature 'style' is defined but not used in any environment
WARN The feature 'testing' is defined but not used in any environment
WARN The feature 'viz' is defined but not used in any environment
WARN The feature 'all' is defined but not used in any environment
'+ptx86' is not a recognized feature for this target (ignoring feature)
'+ptx86' is not a recognized feature for this target (ignoring feature)
'+ptx86' is not a recognized feature for this target (ignoring feature)
'+ptx86' is not a recognized feature for this target (ignoring feature)
'+ptx86' is not a recognized feature for this target (ignoring feature)
'+ptx86' is not a recognized feature for this target (ignoring feature) |
Can you please upload your |
You're right, it still does not work. I'm currently using |
a36408e
to
c3b6c08
Compare
Can you try now @flferretti? The resolved environment now seems working here after the last push. |
c3b6c08
to
5c42e89
Compare
It works now, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Diego, LGTM!
5c42e89
to
a693cf6
Compare
📚 Documentation preview 📚: https://jaxsim--281.org.readthedocs.build//281/