Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark the use of Colab for the examples as broken #152

Merged
merged 1 commit into from
May 15, 2024
Merged

Mark the use of Colab for the examples as broken #152

merged 1 commit into from
May 15, 2024

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented May 15, 2024 •
edited by github-actions bot
Loading

From ami-iit/rod#32

📚 Documentation preview 📚: https://jaxsim--152.org.readthedocs.build//152/

@flferretti flferretti self-assigned this May 15, 2024
traversaro
traversaro approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to just get rid of the colab links as listing as Option 1 something broken is confusing, and colab links are present before the Option 1 section, but for sure it is better then before!

@diegoferigo
Copy link
Member

If it is not working, I'd remove the whole Colab option. We can add it back as soon as it gets fixed.

@diegoferigo
Copy link
Member

Regardless, I believe people might be interested in using Colab for trying running JaxSim on TPUs beyond GPUs. Something to keep in mind is that TPU support is blocked by #136. I have a fix in WIP, but then got caught up on other things with higher priority.

diegoferigo
diegoferigo approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no need to remove from the notebooks the colab-related sections, but it's ok. It could be a good occasion for moving in the future that piece of code somewhere inside jaxsim so that it can be applied with a one-liner to future Colab notebooks.

@flferretti flferretti merged commit bab6755 into main May 15, 2024
29 checks passed
@flferretti flferretti deleted the flferretti-patch-2 branch May 15, 2024 15:01
@flferretti flferretti mentioned this pull request May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

@diegoferigo diegoferigo diegoferigo approved these changes

Assignees

@flferretti flferretti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flferretti @diegoferigo @traversaro