Test for stillborn entities #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the test case! #66 should fix it... |
kvark
added a commit
that referenced
this pull request
Jul 8, 2016
|
Great stuff, thank you @malleusinferni , you rock! |
ghost
merged commit
xMAC94x
pushed a commit
to xMAC94x/specs
that referenced
this pull request
Mar 10, 2021
135: Update hashbrown requirement from 0.2.0 to 0.3.0 r=torkleyy a=dependabot[bot] Updates the requirements on [hashbrown](https://github.com/Amanieu/hashbrown) to permit the latest version. <details> <summary>Changelog</summary> *Sourced from [hashbrown's changelog](https://github.com/Amanieu/hashbrown/blob/master/CHANGELOG.md).* > ## [v0.3.0] - 2019-04-23 > > ### Changed > - Changed shrink_to to not panic if min_capacity < capacity. ([amethyst#67](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/67)) > > ### Fixed > - Worked around emscripten bug emscripten-core/emscripten-fastcomp#258. ([amethyst#66](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/66)) > > ## [v0.2.2] - 2019-04-16 > > ### Fixed > - Inlined non-nightly lowest_set_bit_nonzero. ([amethyst#64](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/64)) > - Fixed build on latest nightly. ([amethyst#65](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/65)) > > ## [v0.2.1] - 2019-04-14 > > ### Changed > - Use for_each in map Extend and FromIterator. ([amethyst#58](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/58)) > - Improved worst-case performance of HashSet.is_subset. ([amethyst#61](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/61)) > > ### Fixed > - Removed incorrect debug_assert. ([amethyst#60](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/60)) > > ## [v0.2.0] - 2019-03-31 > > ### Changed > - The code has been updated to Rust 2018 edition. This means that the minimum > Rust version has been bumped to 1.31 (2018 edition). > > ### Added > - Added `insert_with_hasher` to the raw_entry API to allow `K: !(Hash + Eq)`. ([amethyst#54](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/54)) > - Added support for using hashbrown as the hash table implementation in libstd. ([amethyst#46](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/46)) > > ### Fixed > - Fixed cargo build with minimal-versions. ([amethyst#45](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/45)) > - Fixed `#[may_dangle]` attributes to match the libstd `HashMap`. ([amethyst#46](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/46)) > - ZST keys and values are now handled properly. ([amethyst#46](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/46)) > > ## [v0.1.8] - 2019-01-14 > > ### Added > - Rayon parallel iterator support ([amethyst#37](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/37)) > - `raw_entry` support ([amethyst#31](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/31)) > - `#[may_dangle]` on nightly ([amethyst#31](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/31)) > - `try_reserve` support ([amethyst#31](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/31)) > > ### Fixed > - Fixed variance on `IterMut`. ([amethyst#31](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/31)) > > ## [v0.1.7] - 2018-12-05 ></tr></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`7e79b0c`](Amanieu/hashbrown@7e79b0c) Version 0.3.0 - [`7e2da14`](Amanieu/hashbrown@7e2da14) Merge [amethyst#67](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/67) - [`8ec72d0`](Amanieu/hashbrown@8ec72d0) Change shrink_to to not panic if min_capacity < capacity - [`ddf59a9`](Amanieu/hashbrown@ddf59a9) Merge [amethyst#66](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/66) - [`6eddbe4`](Amanieu/hashbrown@6eddbe4) Work around emscripten bug emscripten-core/emscripten-fastcomp#258 - [`7dbd666`](Amanieu/hashbrown@7dbd666) Version 0.2.2 - [`12e8bb9`](Amanieu/hashbrown@12e8bb9) Merge [amethyst#64](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/64) - [`a657af5`](Amanieu/hashbrown@a657af5) Merge [amethyst#65](https://github-redirect.dependabot.com/Amanieu/hashbrown/issues/65) - [`373a9d4`](Amanieu/hashbrown@373a9d4) Fix warning on latest nightly - [`79c5b41`](Amanieu/hashbrown@79c5b41) Inline non-nightly lowest_set_bit_nonzero - Additional commits viewable in [compare view](Amanieu/hashbrown@v0.2.0...v0.3.0) </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details> Co-authored-by: dependabot[bot] <[email protected]>
xMAC94x
pushed a commit
to xMAC94x/specs
that referenced
this pull request
Mar 10, 2021
142: Update hashbrown requirement from 0.3.0 to 0.4.0 r=torkleyy a=dependabot-preview[bot] Updates the requirements on [hashbrown](https://github.com/rust-lang/hashbrown) to permit the latest version. <details> <summary>Changelog</summary> *Sourced from [hashbrown's changelog](https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md).* > ## [v0.4.0] - 2019-05-30 > > ### Fixed > - Fixed `Send` trait bounds on `IterMut` not matching the libstd one. ([amethyst#82](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/82)) > > ## [v0.3.1] - 2019-05-30 > > ### Fixed > - Fixed incorrect use of slice in unsafe code. ([amethyst#80](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/80)) > > ## [v0.3.0] - 2019-04-23 > > ### Changed > - Changed shrink_to to not panic if min_capacity < capacity. ([amethyst#67](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/67)) > > ### Fixed > - Worked around emscripten bug emscripten-core/emscripten-fastcomp#258. ([amethyst#66](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/66)) > > ## [v0.2.2] - 2019-04-16 > > ### Fixed > - Inlined non-nightly lowest_set_bit_nonzero. ([amethyst#64](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/64)) > - Fixed build on latest nightly. ([amethyst#65](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/65)) > > ## [v0.2.1] - 2019-04-14 > > ### Changed > - Use for_each in map Extend and FromIterator. ([amethyst#58](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/58)) > - Improved worst-case performance of HashSet.is_subset. ([amethyst#61](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/61)) > > ### Fixed > - Removed incorrect debug_assert. ([amethyst#60](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/60)) > > ## [v0.2.0] - 2019-03-31 > > ### Changed > - The code has been updated to Rust 2018 edition. This means that the minimum > Rust version has been bumped to 1.31 (2018 edition). > > ### Added > - Added `insert_with_hasher` to the raw_entry API to allow `K: !(Hash + Eq)`. ([amethyst#54](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/54)) > - Added support for using hashbrown as the hash table implementation in libstd. ([amethyst#46](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/46)) > > ### Fixed > - Fixed cargo build with minimal-versions. ([amethyst#45](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/45)) > - Fixed `#[may_dangle]` attributes to match the libstd `HashMap`. ([amethyst#46](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/46)) > - ZST keys and values are now handled properly. ([amethyst#46](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/46)) > > ## [v0.1.8] - 2019-01-14 > ></tr></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`987b962`](rust-lang/hashbrown@987b962) Version 0.4.0 - [`a9ddbcf`](rust-lang/hashbrown@a9ddbcf) Auto merge of [amethyst#82](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/82) - Amanieu:itermut_send, r=Amanieu - [`a4eba4f`](rust-lang/hashbrown@a4eba4f) Fix the bounds on K for the Send impl of IterMut - [`1889600`](rust-lang/hashbrown@1889600) Version 0.3.1 - [`c765ea0`](rust-lang/hashbrown@c765ea0) Auto merge of [amethyst#80](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/80) - RalfJung:raw, r=Amanieu - [`2693d12`](rust-lang/hashbrown@2693d12) cast the entire slice to a raw pointer, not just the first element - [`4368aa4`](rust-lang/hashbrown@4368aa4) Auto merge of [amethyst#78](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/78) - RalfJung:miri, r=Amanieu - [`419f2ac`](rust-lang/hashbrown@419f2ac) skip Miri tests if the setup fails - [`538d149`](rust-lang/hashbrown@538d149) Merge pull request [amethyst#77](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/77) from lzutao/refresh-doc - [`70afa1b`](rust-lang/hashbrown@70afa1b) Use docs.rs badge - Additional commits viewable in [compare view](rust-lang/hashbrown@v0.3.0...v0.4.0) </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details> [//]: # (dependabot-acquisition-announcement-start) --- <a href='https://dependabot.com/blog/hello-github/'><img width='376' alt='Dependabot has been acquired by GitHub 🎉' src='https://user-images.githubusercontent.com/20165/58035530-e739b700-7b20-11e9-9d1b-12a7630b84e0.png'></a> [//]: # (dependabot-acquisition-announcement-end) Co-authored-by: dependabot-preview[bot] <dependabot-preview[bot]@users.noreply.github.com>
xMAC94x
pushed a commit
to xMAC94x/specs
that referenced
this pull request
Mar 10, 2021
143: Update hashbrown requirement from 0.4.0 to 0.5.0 r=torkleyy a=dependabot-preview[bot] Updates the requirements on [hashbrown](https://github.com/rust-lang/hashbrown) to permit the latest version. <details> <summary>Changelog</summary> *Sourced from [hashbrown's changelog](https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md).* > ## [v0.5.0] - 2019-06-12 > > ### Fixed > - Resize with a more conservative amount of space after deletions. ([amethyst#86](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/86)) > > ### Changed > - Exposed the Layout of the failed allocation in CollectionAllocErr::AllocErr. ([amethyst#89](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/89)) > > ## [v0.4.0] - 2019-05-30 > > ### Fixed > - Fixed `Send` trait bounds on `IterMut` not matching the libstd one. ([amethyst#82](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/82)) > > ## [v0.3.1] - 2019-05-30 > > ### Fixed > - Fixed incorrect use of slice in unsafe code. ([amethyst#80](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/80)) > > ## [v0.3.0] - 2019-04-23 > > ### Changed > - Changed shrink_to to not panic if min_capacity < capacity. ([amethyst#67](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/67)) > > ### Fixed > - Worked around emscripten bug emscripten-core/emscripten-fastcomp#258. ([amethyst#66](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/66)) > > ## [v0.2.2] - 2019-04-16 > > ### Fixed > - Inlined non-nightly lowest_set_bit_nonzero. ([amethyst#64](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/64)) > - Fixed build on latest nightly. ([amethyst#65](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/65)) > > ## [v0.2.1] - 2019-04-14 > > ### Changed > - Use for_each in map Extend and FromIterator. ([amethyst#58](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/58)) > - Improved worst-case performance of HashSet.is_subset. ([amethyst#61](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/61)) > > ### Fixed > - Removed incorrect debug_assert. ([amethyst#60](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/60)) > > ## [v0.2.0] - 2019-03-31 > > ### Changed > - The code has been updated to Rust 2018 edition. This means that the minimum > Rust version has been bumped to 1.31 (2018 edition). > > ### Added > - Added `insert_with_hasher` to the raw_entry API to allow `K: !(Hash + Eq)`. ([amethyst#54](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/54)) > - Added support for using hashbrown as the hash table implementation in libstd. ([amethyst#46](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/46)) ></tr></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`e7cd4a5`](rust-lang/hashbrown@e7cd4a5) Version 0.5.0 - [`2c16341`](rust-lang/hashbrown@2c16341) Auto merge of [amethyst#89](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/89) - SimonSapin:layout, r=Amanieu - [`c2e26e7`](rust-lang/hashbrown@c2e26e7) Expose the Layout of the failed allocation in CollectionAllocErr::AllocErr - [`14bb115`](rust-lang/hashbrown@14bb115) Auto merge of [amethyst#87](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/87) - josephrocca:patch-1, r=Amanieu - [`80dc544`](rust-lang/hashbrown@80dc544) Add simple usage code - [`b240ee0`](rust-lang/hashbrown@b240ee0) Auto merge of [amethyst#86](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/86) - edre:rehash, r=Amanieu - [`afc20d7`](rust-lang/hashbrown@afc20d7) Resize with a more conservative amount of space when inserting after deletions. - [`119f429`](rust-lang/hashbrown@119f429) Auto merge of [amethyst#84](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/84) - edre:bench, r=Amanieu - [`8783490`](rust-lang/hashbrown@8783490) Update insert_erase benchmark to keep the table size constant. - [`143609d`](rust-lang/hashbrown@143609d) Auto merge of [amethyst#83](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/83) - edre:bench, r=Amanieu - Additional commits viewable in [compare view](rust-lang/hashbrown@v0.4.0...v0.5.0) </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details> Co-authored-by: dependabot-preview[bot] <dependabot-preview[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a failing test addressing dynamic creation and deletion of entities in different systems. The core intent is to check whether components can be inserted immediately after entity creation. Note that in a test which only creates entities (ie. without deleting any) I was not able to detect the problem this test is designed to highlight.
cc @kvark