Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constructing entities manually #77

Closed
Aceeri opened this issue Oct 12, 2016 · 2 comments
Closed

Constructing entities manually #77

Aceeri opened this issue Oct 12, 2016 · 2 comments

Comments

@Aceeri
Copy link
Member

Aceeri commented Oct 12, 2016 •
edited
Loading

Would be nice to be able to store a u32 and i32 instead of storing an Entity, mainly for Atomic types.

Are there any problems related to making the declaration pub struct Generation(pub i32)? Or maybe having a constructor for it?
@kvark
Copy link
Member

kvark commented Oct 14, 2016

That sounds quite unsafe. We could add an unsafe constructor for Generation if you have a use case.

@kvark kvark closed this as completed Oct 14, 2016
@kvark kvark reopened this Oct 14, 2016
@Aceeri
Copy link
Member Author

Aceeri commented Oct 14, 2016

No longer a problem for me at least. I was just trying to store an Entity atomically.

@Aceeri Aceeri closed this as completed Nov 16, 2016
xMAC94x pushed a commit to xMAC94x/specs that referenced this issue Mar 10, 2021
@bors
Merge amethyst#77
3cc6aae 
77: Solve the "resource not found" problem r=torkleyy a=torkleyy

In the past, many users had difficulties with panics just saying "No resource with the given id". This is neither beginner friendly, nor a good way to handle the error.

The default behavior has been changed to adding the missing resource automatically. For this, a `Default` implementation needs to be in place.

In case a resource does not have a `Default` implementation, it's recommended that one uses `Option<Fetch>` and checks whether the resource exists or not. If the system cannot work without the resource, it should simply `return`.

In case the resource is absolutely required and the user is sure it exists, they can use `FetchExpect`. It is pretty much like `Fetch` was before, but now the panic message has been improved and there's a `nightly` feature that also prints the type name of the missing resource.

The overall goal is to make `shred` more robust, easier to debug and beginner-friendly.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/slide-rs/shred/77)
<!-- Reviewable:end -->
xMAC94x pushed a commit to xMAC94x/specs that referenced this issue Mar 10, 2021
@bors @dependabot-preview
Merge amethyst#142
cf82d3d 
142: Update hashbrown requirement from 0.3.0 to 0.4.0 r=torkleyy a=dependabot-preview[bot]

Updates the requirements on [hashbrown](https://github.com/rust-lang/hashbrown) to permit the latest version.
<details>
<summary>Changelog</summary>

*Sourced from [hashbrown's changelog](https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md).*

> ## [v0.4.0] - 2019-05-30
> 
> ### Fixed
> - Fixed `Send` trait bounds on `IterMut` not matching the libstd one. ([amethyst#82](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/82))
> 
> ## [v0.3.1] - 2019-05-30
> 
> ### Fixed
> - Fixed incorrect use of slice in unsafe code. ([amethyst#80](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/80))
> 
> ## [v0.3.0] - 2019-04-23
> 
> ### Changed
> - Changed shrink_to to not panic if min_capacity < capacity. ([amethyst#67](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/67))
> 
> ### Fixed
> - Worked around emscripten bug emscripten-core/emscripten-fastcomp#258. ([amethyst#66](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/66))
> 
> ## [v0.2.2] - 2019-04-16
> 
> ### Fixed
> - Inlined non-nightly lowest_set_bit_nonzero. ([amethyst#64](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/64))
> - Fixed build on latest nightly. ([amethyst#65](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/65))
> 
> ## [v0.2.1] - 2019-04-14
> 
> ### Changed
> - Use for_each in map Extend and FromIterator. ([amethyst#58](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/58))
> - Improved worst-case performance of HashSet.is_subset. ([amethyst#61](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/61))
> 
> ### Fixed
> - Removed incorrect debug_assert. ([amethyst#60](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/60))
> 
> ## [v0.2.0] - 2019-03-31
> 
> ### Changed
> - The code has been updated to Rust 2018 edition. This means that the minimum
>   Rust version has been bumped to 1.31 (2018 edition).
> 
> ### Added
> - Added `insert_with_hasher` to the raw_entry API to allow `K: !(Hash + Eq)`. ([amethyst#54](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/54))
> - Added support for using hashbrown as the hash table implementation in libstd. ([amethyst#46](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/46))
> 
> ### Fixed
> - Fixed cargo build with minimal-versions. ([amethyst#45](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/45))
> - Fixed `#[may_dangle]` attributes to match the libstd `HashMap`. ([amethyst#46](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/46))
> - ZST keys and values are now handled properly. ([amethyst#46](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/46))
> 
> ## [v0.1.8] - 2019-01-14
> 
></tr></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- [`987b962`](rust-lang/hashbrown@987b962) Version 0.4.0
- [`a9ddbcf`](rust-lang/hashbrown@a9ddbcf) Auto merge of [amethyst#82](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/82) - Amanieu:itermut_send, r=Amanieu
- [`a4eba4f`](rust-lang/hashbrown@a4eba4f) Fix the bounds on K for the Send impl of IterMut
- [`1889600`](rust-lang/hashbrown@1889600) Version 0.3.1
- [`c765ea0`](rust-lang/hashbrown@c765ea0) Auto merge of [amethyst#80](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/80) - RalfJung:raw, r=Amanieu
- [`2693d12`](rust-lang/hashbrown@2693d12) cast the entire slice to a raw pointer, not just the first element
- [`4368aa4`](rust-lang/hashbrown@4368aa4) Auto merge of [amethyst#78](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/78) - RalfJung:miri, r=Amanieu
- [`419f2ac`](rust-lang/hashbrown@419f2ac) skip Miri tests if the setup fails
- [`538d149`](rust-lang/hashbrown@538d149) Merge pull request [amethyst#77](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/77) from lzutao/refresh-doc
- [`70afa1b`](rust-lang/hashbrown@70afa1b) Use docs.rs badge
- Additional commits viewable in [compare view](rust-lang/hashbrown@v0.3.0...v0.4.0)
</details>
<br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

[//]: # (dependabot-acquisition-announcement-start)

---

<a href='https://dependabot.com/blog/hello-github/'><img width='376' alt='Dependabot has been acquired by GitHub  🎉' src='https://user-images.githubusercontent.com/20165/58035530-e739b700-7b20-11e9-9d1b-12a7630b84e0.png'></a>

[//]: # (dependabot-acquisition-announcement-end)

Co-authored-by: dependabot-preview[bot] <dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvark @Aceeri