-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally use sed extended regex syntax #453
Merged
Ph0enixKM
merged 5 commits into
amber-lang:master
from
hdwalters:use-sed-extended-regex
Sep 11, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
89f4d82
Optionally use sed extended regex syntax.
hdwalters d633701
Update src/std/text.ab
hdwalters 62daf3b
Add comment stating that sed extended regex may fail on some older Li…
hdwalters d902b19
Change regex used to detect GNU sed.
hdwalters aed7346
Remove duplicate unsafe from stdlib function.
hdwalters File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import * from "std/text" | ||
|
||
// Output | ||
// abc[123]def | ||
|
||
main { | ||
echo replace_regex("abc123def", "\([0-9][0-9]*\)", "[\1]") | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import * from "std/text" | ||
|
||
// Output | ||
// abc[123]def | ||
|
||
main { | ||
// This will fail on any system where sed does not support extended | ||
// regex syntax, via "-r" on GNU sed and "-E" on all other versions. | ||
echo replace_regex("abc123def", "([0-9]+)", "[\1]", true) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test would fail on a machine that does not support the new flag, right? Can we at least write a note somewhere or maybe even skip this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to keep the test, because it confirms that on systems which do support
-E
or-r
, the right option is being used. And while Amber may be run on older systems, I doubt that anyone will runcargo test
on them. Would you be happy with a comment in the test file?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... I think that we should create some syntax for interfacing commands given different versions and os's. This way we could just run the sed through that interface and never worry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, would need to give it some thought, but happy to discuss. In the meantime, I've added this warning comment. Does this resolve your immediate request?