161355ee6d2c64c0c4853a0646795028d666f052^..2059c5e3b06545e7d0650dba9c665332374c3c21 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not customary to install a shared library with a minor version number (libpq.5.16.dylib) on macOS. We just need the file with the major version number (libpq.5.dylib) and the one without version number (libpq.dylib). This also matches the installation layout used by Meson. Discussion: https://www.postgresql.org/message-id/[email protected] (cherry picked from commit 161355ee6d2c64c0c4853a0646795028d666f052)
These should have been included in 421892a19 as these shadowed variable warnings can also be fixed by adjusting the scope of the shadowed variable to put the declaration for it in an inner scope. This is part of the same effort as f01592f91. By my count, this takes the warning count from 114 down to 106. Author: David Rowley and Justin Pryzby Discussion: https://postgr.es/m/CAApHDvrwLGBP%2BYw9vriayyf%3DXR4uPWP5jr6cQhP9au_kaDUhbA%40mail.gmail.com (cherry picked from commit f959bf9a5b9cecd2f6e6bdd24a34a7b269b00827)
This stuff should be already initialized at process startup, so adding this extra step is confusing for no gain. Per gripe from Tom Lane and Jacob Champion. Discussion: https://postgr.es/m/[email protected] (cherry picked from commit 701ac2cb1fa25ca0b8572e87073d9008ed406b55)
The code took the LOCALE option as the default/fallback for ICU_LOCALE, but this was neither documented nor intended, so remove it. (It was probably left in from an earlier patch version.) Reported-by: Marina Polyakova <[email protected]> Discussion: https://www.postgresql.org/message-id/flat/f385ba25e7f8be427b8c582e5cca7d79%40postgrespro.ru#515a31c5429d6d37ad1d5c9d66962a1e (cherry picked from commit 8b808f189fb1f62a6830e5c023f4ae49a1f4c9a8)
Author: Shinya Kato Discussion: https://postgr.es/m/[email protected] Backpatch-through: 15, where that change was introduced (cherry picked from commit a73d6c87f2eb19681fe52d6d8bb7db38a7a7da2a)
SplitToVariants() in the ispell code, lseg_inside_poly() in geo_ops.c, and regex_selectivity_sub() in selectivity estimation could recurse until stack overflow; fix by adding check_stack_depth() calls. So could next() in the regex compiler, but that case is better fixed by converting its tail recursion to a loop. (We probably get better code that way too, since next() can now be inlined into its sole caller.) There remains a reachable stack overrun in the Turkish stemmer, but we'll need some advice from the Snowball people about how to fix that. Per report from Egor Chindyaskin and Alexander Lakhin. These mistakes are old, so back-patch to all supported branches. Richard Guo and Tom Lane Discussion: https://postgr.es/m/[email protected] (cherry picked from commit f25bed3801e1e500850a9f3b29a003c644d4bd6d)
This was forgotten when the new column was introduced. Author: Marina Polyakova <[email protected]> Reviewed-by: Julien Rouhaud <[email protected]> Discussion: https://www.postgresql.org/message-id/7ad26354e75259f59c4a6c6997b8ee32%40postgrespro.ru (cherry picked from commit 396d348b046c6b7e5dc83158c4c1df1377a1d2ef)
This is preparatory work for a project to increase the number of bits in a RelFileNumber from 32 to 56. Along the way, introduce static inline accessor functions for a couple of BufferTag fields. Dilip Kumar, reviewed by me. The overall patch series has also had review at various times from Andres Freund, Ashutosh Sharma, Hannu Krosing, Vignesh C, Álvaro Herrera, and Tom Lane. Discussion: http://postgr.es/m/CAFiTN-trubju5YbWAq-BSpZ90-Z6xCVBQE8BVqXqANOZAF1Znw@mail.gmail.com (cherry picked from commit 82ac34db2036ec5b3cb32c9180f40549aa790dc2)
-Bsymbolic causes a lot of "ld: warning: symbol referencing errors" warnings. It's quite easy to add the symbol versioning script, we just need a slightly different parameter name. Reviewed-by: Peter Eisentraut <[email protected]> Discussion: https://postgr.es/m/[email protected] Discussion: https://postgr.es/m/[email protected] (cherry picked from commit 3fb0687d328b8eef6ab0ff80300e5746f4a777cb)
Discussion: https://postgr.es/m/[email protected] (cherry picked from commit 68fc18d14c7e1150823cf4a5728089459723c9da)
Apparently I missed that this SUBSYS.o rule isn't needed anymore in a4ebbd2, likely because there still is a reference to it due to AIX - but that's self contained in src/backend/Makefile Discussion: https://postgr.es/m/[email protected] (cherry picked from commit 05bf551040ba161ddfbf7da308d61d2b7b425bf3)
The dependencies here aren't quite right independent of vpath builds or not, but this at least makes vpath builds succeed. And it's pretty rare to change the exports.txt file anyway... The referenced thread has a patch that will clean that up further. Discussion: https://postgr.es/m/[email protected] (cherry picked from commit 4444317f370cbbd6a9bb62d70dd8f1f062952ef4)
ICU doesn't support some server encodings, so we need to exclude them if a non-supported encoding was set up. (cherry picked from commit b4ddf3ee30bfb5b7da60411cabcf0589bdbd3f42)
This was added as a possible variant of __aarch64__ back when 64-bit ARM was vaporware. It hasn't shown up in the wild since then, so remove. Nathan Bossart Discussion: https://www.postgresql.org/message-id/CAFBsxsEN5nW3uRh%3Djrs-QexDrC1btu0ZfriD3FFfb%3D3J6tAngg%40mail.gmail.com (cherry picked from commit 4112e39f70eed8d699ea5be7f5945a8970023d0d)
The optimization is named kill_prior_tuple but was accidentally spelled kill_prio_tuple in the test. Author: Mingli Zhang <[email protected]> Discussion: https://postgr.es/m/82d3e66a-d8ae-4bfa-943e-29c5add0743f@Spark (cherry picked from commit 0c67e9e566db32df3f420268e81e32f278a2f090)
Commit ce6b672e445 accidentally introduced a trivial typo in the documentation for GRANT. (cherry picked from commit d16c99aa71047e3cd94dad85f9fa82a7d6f94eed)
(cherry picked from commit 421ccaa6272a2935a3d2e578ff6feeeeab7d8848)
It is not needed at the scope of c.h, only in backend code. Reviewed-by: Tom Lane <[email protected]> Discussion: https://www.postgresql.org/message-id/flat/a6a6b48e-ca0a-b58d-18de-98e40d94b842%40enterprisedb.com (cherry picked from commit 2059c5e3b06545e7d0650dba9c665332374c3c21)
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 1, 2023
Signed-off-by: Jason Teng <[email protected]>
2jungkook
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
18 commits, no merge conflicts.
Extension PR for validation: amazon-aurora/babelfish_extensions#54