Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge conflict in b3a0d8324cf1f02c04a7099a436cfd68cfbf4566 Move snowball_create.sql creation into perl file #66

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

Sairakan
Copy link

@Sairakan Sairakan commented Nov 30, 2023

Conflict occurs due to changing how the snowball dicts are compiled when we had modified the Makefile to add tsql_contains.stop. Resolved by taking in new changes in the Makefile and adding in an extra reference to tsql_contains in the newly created stop file list in the Makefile.

Extension PR for validation: amazon-aurora/babelfish_extensions#54

Merge conflict in src/backend/snowball/Makefile
install: all installdirs install-lib
	$(INSTALL_DATA) $(SQLSCRIPT) '$(DESTDIR)$(datadir)'
<<<<<<< ours
	@set -e; \
	set $(LANGUAGES) ; \
	while [ "$$#" -gt 0 ] ; \
	do \
		lang=$$1; shift; shift; \
		$(INSTALL_DATA) $(srcdir)/stopwords/tsql_contains.stop '$(DESTDIR)$(datadir)/$(DICTDIR)' ; \
		if [ -s $(srcdir)/stopwords/$${lang}.stop ] ; then \
			$(INSTALL_DATA) $(srcdir)/stopwords/$${lang}.stop '$(DESTDIR)$(datadir)/$(DICTDIR)' ; \
		fi \
	done
=======
	$(INSTALL_DATA) $(addprefix $(srcdir)/stopwords/,$(stop_files)) '$(DESTDIR)$(datadir)/$(DICTDIR)'

uninstall: uninstall-lib
	rm -f '$(DESTDIR)$(datadir)/$(SQLSCRIPT)'
<<<<<<< ours
	@set -e; \
	set $(LANGUAGES) ; \
	while [ "$$#" -gt 0 ] ; \
	do \
		lang=$$1; shift; shift;  \
		rm -f '$(DESTDIR)$(datadir)/$(DICTDIR)/'tsql_contains.stop ; \
		if [ -s $(srcdir)/stopwords/$${lang}.stop ] ; then \
		    rm -f '$(DESTDIR)$(datadir)/$(DICTDIR)/'$${lang}.stop ; \
		fi \
	done

clean distclean maintainer-clean: clean-lib
	rm -f $(OBJS) $(SQLSCRIPT)
=======
	rm -f $(addprefix '$(DESTDIR)$(datadir)/$(DICTDIR)/',$(stop_files))

clean distclean: clean-lib
	rm -f $(OBJS)

maintainer-clean: distclean
	rm -f $(SQLSCRIPT)
>>>>>>> theirs

Sairakan pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Nov 30, 2023
BABELFISH-CONFLICT: see Postgres community repo for original commit

This is in preparation for building postgres with meson / ninja.

We already have duplicated code for this between the make and msvc
builds. Adding a third copy seems like a bad plan, thus move the generation
into a perl script.

As we don't want to rely on perl being available for builds from tarballs,
generate the file during distprep.

Author: Peter Eisentraut <[email protected]>
Author: Andres Freund <[email protected]>
Discussion: https://postgr.es/m/[email protected]
(cherry picked from commit b3a0d8324cf1f02c04a7099a436cfd68cfbf4566)
@Sairakan Sairakan force-pushed the pg16-cherry-pick-bff-1 branch from 230f304 to 763a80d Compare November 30, 2023 20:46
russian.stop \
spanish.stop \
swedish.stop \
tsql_contains.stop \
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babelfish-specific line added here

Sairakan pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Nov 30, 2023
@2jungkook 2jungkook merged commit 389028d into BABEL_main Nov 30, 2023
4 checks passed
@2jungkook 2jungkook deleted the pg16-cherry-pick-bff-1 branch November 30, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants