fix missing utilities in Windows wheels #22
Conversation
There was a problem hiding this comment.
Thanks for taking the time to identify the solution here. Hopefully we don't end up missing deps. Other platforms don't have windeployqt so at some point I should just stop using it entirely I guess...
I think the important bits of your changes can be added within the existing structure. Let me know what you think of my suggested form.
Cheers,
-kyle
Some utilities, like `rcc.exe`, were getting filtered-out: handle the fact that those are "not a Qt executable", as reported by `windeployqt`, but we still want to include them.
benoit-pierre
force-pushed
the
fix_missing_utilities_in_windows_wheels
branch
from
536dfac to
6206603
Compare
|
The checks have passed, but the Github Actions run is still failed!? And the error is less than helpful: |
|
Too many matrix combinations for the test job? |
|
|
Yes, I have started to trim that down. At least in #20, I forget exactly. |
|
Maybe you could start by dropping Python 3.5 support, since it reached EOL a year ago. |
|
Any news on this? 😄 |
|
Merging as is and will explore the results in fresh builds in #23. Thank you for the work and I apologize for the delayed resolution. |
Some utilities, like
rcc.exe, were getting filtered-out: handlethe fact that those are "not a Qt executable", as reported bywindeployqt, but we still want to include them.Close #21.