Skip to content

Commit

Permalink
Merge pull request #22 from benoit-pierre/fix_missing_utilities_in_wi…
Browse files Browse the repository at this point in the history
…ndows_wheels

fix missing utilities in Windows wheels
  • Loading branch information
altendky authored Mar 26, 2023
2 parents 3605008 + 6206603 commit 4f9723f
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion build.py
Original file line number Diff line number Diff line change
Expand Up @@ -1194,11 +1194,15 @@ def windeployqt_list_source(
target,
],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
# ugh, 3.5
# encoding='utf-8',
)
except subprocess.CalledProcessError as e:
raise DependencyCollectionError(target) from e
if 'does not seem to be a Qt executable' in e.stderr.decode('utf-8'):
# This can happen with some utilities like
# `rcc.exe`, which we still want to include.
return []

paths = [
pathlib.Path(line)
Expand Down

0 comments on commit 4f9723f

Please sign in to comment.