Only support symbol keys in component arguments #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes transitional change that supported accessing by string or symbol key. Once clients calling components with string keys have been updated to use symbol keys this can be merged. Related: - alphagov/finder-frontend#217 - alphagov/manuals-frontend#147 - #601
3 tasks
edds
added a commit
that referenced
this pull request
Jun 16, 2015
Only support symbol keys in component arguments
dsingleton
pushed a commit
that referenced
this pull request
Oct 21, 2015
Fixtures/the component guide generate an object with symbol keys, as this is the convention of GOV.UK components, as we had confusion between symbol and string keys, see: #602 Analytics Metadata is an exception, because it's passed ContentItem object directly from the `content_store` API, which will always have string keys. This also changes the structure of link sub-hashes to match the structure expected by the component template, specifically, it expects a field called `analytics_identifier` for a link, not the link to have that as it's value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes transitional change that supported accessing by string
or symbol key.
Once clients calling components with string keys have been updated
to use symbol keys this can be merged.
Related:
It's worth reading the discussion on the PR that added the transitional support for either kind of key, it outlines the reasoning there: #601