This repository has been archived by the owner on Jan 24, 2018. It is now read-only.
Only support symbol keys for fixure hashes #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some components templates in static use symbol keys and some use strings, which is inconsistent and confusing, this helps us standardise on symbols, by only supporting sumbol in guide fixtures. However the copy/pastable example for a fixture all use symbol keys, meaning that copy/pasting them into an app would not work if the component on static used symbols. Previously the difference was masked with `with_indifferent_access`, allowing both types of keys. Only using symbols means any component trying to access an object by stirng key will not display the right data for that key. This should be more obvious to someone checking the component within the guide. Longer term we might want to add testing that would also catch this, but for now we can rely on component changes being tested against the guide and key problems spotted.
dsingleton
changed the title
edds
added a commit
that referenced
this pull request
Jun 16, 2015
Only support symbol keys for fixure hashes
dsingleton
added a commit
to alphagov/static
that referenced
this pull request
Jul 2, 2015
Some components templates in static were using symbol keys and others strings, which was inconsistent and confusing, by only using symbols we avoid confusion. Tools like the component guide have been updated so they will obviously error when strings are used - previously it silently corrected any string/key mismatch. More here: alphagov/govuk-component-guide#20
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can be merged after 1. otherwise it will break the previewing
of the components using string keys.
Some components templates in static use symbol keys and some use
strings, which is inconsistent and confusing, this helps us
standardise on symbols, by only supporting symbol in guide fixtures.
However the copy/pastable example for a fixture all use symbol keys,
meaning that copy/pasting them into an app would not work if the
component on static used symbols.
Previously the difference was masked with
with_indifferent_access,allowing both types of keys. Only using symbols means any component
trying to access an object by string key will not display the right
data for that key. This should be more obvious to someone checking
the component within the guide.
Longer term we might want to add testing that would also catch this,
but for now we can rely on component changes being tested against
the guide and key problems spotted.