Clean up scripts #2405
Merged
Clean up scripts #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-ju
force-pushed
the
replace-scripts-with-gem-equivalents
branch
from
4f9f159 to
1c0d98a
Compare
alex-ju
force-pushed
the
replace-scripts-with-gem-equivalents
branch
from
1c0d98a to
58af2e9
Compare
alex-ju
force-pushed
the
replace-scripts-with-gem-equivalents
branch
3 times, most recently
from
9e8fa85 to
556cef1
Compare
This was referenced Feb 18, 2021
alex-ju
force-pushed
the
replace-scripts-with-gem-equivalents
branch
from
556cef1 to
a68b3e5
Compare
|
Rebased and e2e tests are passing now, as expected after the app-level changes have been merged. Update: All public-facing applications relying on |
injms
approved these changes
Mar 2, 2021
The equivalent gem versions are rewritten using the prototype pattern and do not depend on jQuery. We point to those versions to prevent further edits on these files in static.
This script is not being used by static and it's already made available to frontend applications via govuk_publishing_components.
This is only being used in `government-frontnend` so we're moving it there instead.
`selection-buttons` was only used in GOV.UK Elements which is deprecated and not required by any application `shim-links-with-button-role` is now embeded in `govuk-frontend` and required by the button component when in use
No evidence of this being used across frontend applications
No evidence of this being used across frontend applications
alex-ju
force-pushed
the
replace-scripts-with-gem-equivalents
branch
from
a68b3e5 to
8615490
Compare
|
Speedcurve results for this change (mobile, 2G) Web vitals
CPU metrics
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Clean up scripts in
static:track-clickwith gem equivalent (requires similar update across frontend apps to switch togem-track-click)togglescript (requires update across frontend apps to switch togem-toggle)sticky-element-containerscript (moved togovernment-frontendas it's not used elsewhere)Why
To reduce the size of assets served to users and keep our codebase to a minimum.
Checklist
Notes
E2E tests are failing for known reasons that will be addressed at the application-level as described above.All public-facing applications relying on static have been updated to use the latest version
govuk_publishing_componentswhere components do not rely ontrack-clickfromstaticanymore.