Switch from trackClick to gemTrackClick script #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
alex-ju
force-pushed
the
use-gem-track-click
branch
from
5e899ae to
57d9bd7
Compare
andysellick
approved these changes
Feb 25, 2021
Merged
This was referenced Mar 11, 2021
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Switch from using
trackClickscript fromstatictogemTrackClickscript from this repo. They are virtually the same, the latter being copied over fromstatictogovuk_publishing_components.Why
Part of a bigger piece of work to reduce the size of assets served to users and keep our codebase to a minimum.
Visual Changes
No visual changes