Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate button & analytics meta tags #1390

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Deprecate button & analytics meta tags #1390

merged 1 commit into from
Apr 24, 2018

Conversation

tijmenb
Copy link
Contributor

@tijmenb tijmenb commented Apr 24, 2018

Link them to the new components in the gem.

cc @andysellick

@tijmenb tijmenb temporarily deployed to govuk-static-pr-1390 April 24, 2018 11:48 Inactive
Link them to the new components in the gem.
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Presumably both these files will go when we remove these components from static anyway?

@tijmenb
Copy link
Contributor Author

tijmenb commented Apr 24, 2018

@andysellick yes!

@tijmenb tijmenb merged commit f83b7a0 into master Apr 24, 2018
@tijmenb tijmenb deleted the deprecate branch April 24, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants