Skip to content

Commit

Permalink
Merge pull request #1390 from alphagov/deprecate
Browse files Browse the repository at this point in the history
Deprecate button & analytics meta tags
  • Loading branch information
tijmenb authored Apr 24, 2018
2 parents 1830791 + a375f33 commit f83b7a0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 23 deletions.
7 changes: 2 additions & 5 deletions app/views/govuk_component/docs/analytics_meta_tags.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
name: Analytics Meta Tags
name: Analytics Meta Tags (deprecated)
description: Meta tags to provide analytics information about the current page
body: |
Currently this just takes a content-store links hash like object which it
can then turn into the correct analytics identifier metadata tags.
The code which reads the meta tags can be found <a href="https://github.com/alphagov/static/blob/master/app/assets/javascripts/analytics/static-analytics.js#L76-L96">in static-analytics.js</a>.
**Don't use this**. Use the [new component in the gem instead](https://govuk-publishing-components.herokuapp.com/component-guide/meta_tags)
accessibility_criteria: |
The analytics meta tags component should not be visible to any users.
examples:
Expand Down
20 changes: 2 additions & 18 deletions app/views/govuk_component/docs/button.yml
Original file line number Diff line number Diff line change
@@ -1,23 +1,7 @@
name: Button
name: Button (deprecated)
description: Use buttons to move though a transaction, aim to use only one button per page.
body: |
Button text should be short and describe the action the button performs.
[GOV.UK Elements has more information](https://govuk-elements.herokuapp.com/buttons/) on how buttons should be used.
Note: We do not consume GOV.UK Elements directly due to the naming conventions being leaky,
in time this component will be a wrapper for the [GOV.UK Frontend](https://github.com/alphagov/govuk-frontend) project's button component.
Global button styles seen at `app/assets/stylesheets/helpers/_buttons.scss`
should be considered deprecated with this component replacing any instances.
govuk-* namespace replaced with pub-c-* otherwise we will conflict with [GOV.UK Frontend's namespace](https://github.com/alphagov/govuk-frontend/blob/master/docs/components.md)
This component is also [extended for use in govspeak](https://govuk-static.herokuapp.com/component-guide/govspeak/button).
These instances of buttons are added by Content Designers, ideally this duplication would not exist but we currently don't have shared markup
via our components within the generated [govspeak](https://github.com/alphagov/govspeak).
(This is a challenge to the reader)
**Don't use this**. Use the [new component in the gem instead](https://govuk-publishing-components.herokuapp.com/component-guide/button)
accessibility_criteria: |
The button must:
Expand Down

0 comments on commit f83b7a0

Please sign in to comment.