Skip to content

Commit

Permalink
Merge pull request #1111 from alphagov/rename-current-to-not-withdrawn
Browse files Browse the repository at this point in the history
Rename "current" to "not withdrawn"
  • Loading branch information
elenatanasoiu authored Aug 11, 2017
2 parents 644d302 + f499cae commit e727de5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/assets/javascripts/analytics/custom-dimensions.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
'political-status': {dimension: 7},
'analytics:organisations': {dimension: 9},
'analytics:world-locations': {dimension: 10},
'withdrawn': {dimension: 12, defaultValue: 'current'},
'withdrawn': {dimension: 12, defaultValue: 'not withdrawn'},
'schema-name': {dimension: 17},
'rendering-application': {dimension: 20},
'navigation-page-type': {dimension: 32, defaultValue: 'none'},
Expand Down
2 changes: 1 addition & 1 deletion spec/javascripts/analytics/ecommerce.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ describe('Ecommerce reporter for results pages', function() {
dimension11: '1',
dimension3: 'other',
dimension4: '00000000-0000-0000-0000-000000000000',
dimension12: 'current',
dimension12: 'not withdrawn',
dimension23: 'unknown',
dimension26: '0',
dimension27: '0',
Expand Down

0 comments on commit e727de5

Please sign in to comment.